title as parameter for TimeSeries.plot() #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madtoinou
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Thank you for this contribution @jonathankoch99! Looks good to me, can you please just add an entry in the Unreleased section of the changelog and it should be ready to be merged!
dennisbader
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Thanks a lot @jonathankoch99 for this PR, and welcome to the Darts community :D 🚀
Just some minor comments, then we can merge.
Co-authored-by: Dennis Bader <[email protected]>
Co-authored-by: Dennis Bader <[email protected]>
dennisbader
approved these changes
Jan 8, 2025
madtoinou
approved these changes
Jan 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2639 +/- ##
==========================================
- Coverage 94.20% 94.15% -0.06%
==========================================
Files 141 141
Lines 15491 15491
==========================================
- Hits 14594 14586 -8
- Misses 897 905 +8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Fixes #2622 .
Summary
Adds the
titleattribute toTimeSeries.plot()as requested in #2622 . If no title is provided as attribute the method reverts to the original behavior.