optlib: allow users to set fields and check extras defined in a foreign language #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3960 +/- ##
==========================================
+ Coverage 85.94% 85.95% +0.01%
==========================================
Files 241 241
Lines 59144 59222 +78
==========================================
+ Hits 50830 50904 +74
- Misses 8314 8318 +4 ☔ View full report in Codecov by Sentry. |
masatake
force-pushed
the
main--foreign-fields
branch
2 times, most recently
from
e14c4e6 to
cbdc8c8
Compare
|
The ways to support boolean fields are not consistent in various aspects. |
masatake
force-pushed
the
main--foreign-fields
branch
2 times, most recently
from
d9408cb to
ae46592
Compare
masatake
force-pushed
the
main--foreign-fields
branch
from
ae46592 to
eba8b2e
Compare
|
I added test cases. The top half of this pull request can be merged. I will make a pull request. |
masatake
force-pushed
the
main--foreign-fields
branch
from
eba8b2e to
c50fcca
Compare
masatake
force-pushed
the
main--foreign-fields
branch
2 times, most recently
from
8f2f83d to
8ea0aa6
Compare
|
This pull request was for a Texinfo parser. |
masatake
force-pushed
the
main--foreign-fields
branch
from
8ea0aa6 to
7805e78
Compare
masatake
force-pushed
the
main--foreign-fields
branch
2 times, most recently
from
4a62955 to
b8b157f
Compare
masatake
force-pushed
the
main--foreign-fields
branch
2 times, most recently
from
2996703 to
a47f1bb
Compare
The operators (setter and/or getter) for each field. The name of operators has following form: setter => <LANG>.<FIELD>: getter => :<LANG>.<FIELD> The operators for a field are defined only if the field has setter and getter in C language level; the operators require getValueObject member and setValueObject member in fieldDefinition are set. Currently, there is no parser specific field setting their members. So, we cannot test the new code added with this commit. In the later commit, I will implement a getter and a setter for fields defined with --_fielddef option. Signed-off-by: Masatake YAMATO <[email protected]>
…ned in an optlib parser Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
…efined in optlib Signed-off-by: Masatake YAMATO <[email protected]>
masatake
force-pushed
the
main--foreign-fields
branch
from
a47f1bb to
0d32e66
Compare
Signed-off-by: Masatake YAMATO <[email protected]>
masatake
force-pushed
the
main--foreign-fields
branch
from
0d32e66 to
84bb07f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, this pull request allows you to fill out a field for a foreign tag from optscript.