main: provide the way to specify data taype in --_fielddef option #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4178 +/- ##
=======================================
Coverage 85.93% 85.94%
=======================================
Files 241 241
Lines 59115 59142 +27
=======================================
+ Hits 50803 50830 +27
Misses 8312 8312 ☔ View full report in Codecov by Sentry. |
--_list-fielddef-flags option is added, too. Signed-off-by: Masatake YAMATO <[email protected]>
Signed-off-by: Masatake YAMATO <[email protected]>
masatake
force-pushed
the
main--datatype-in-fielddef
branch
from
0582c06 to
1461664
Compare
masatake
changed the title
masatake
commented
Jan 22, 2025
| { | ||
| $datatype .= "FIELDTYPE_BOOL"; | ||
| } | ||
| elsif (($1 eq 'bool+str') || ($1 eq 'str+bool')) |
There was a problem hiding this comment.
bool+str should be rejected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation step for implementing optscript operators getting and setting parser-specific fields.