Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude "@unstoppabledomains" from logging warning #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −1
Open

Exclude "@unstoppabledomains" from logging warning #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
749a650
Exclude "@unstoppabledomains" from logging warning
osa911 Dec 11, 2024
e57e411
bump version
osa911 Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/app/src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,12 @@ export function registerVersion(
if (variant) {
library += `-${variant}`;
}

if (library.includes('@unstoppabledomains')) {
// we don't want to log warning for unstoppabledomains
return;
}

const libraryMismatch = library.match(/\s|\//);
const versionMismatch = version.match(/\s|\//);
if (libraryMismatch || versionMismatch) {
Expand Down
2 changes: 1 addition & 1 deletion packages/auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@unstoppabledomains/firebase-auth",
"version": "1.5.6",
"version": "1.5.7",
Copy link

@helfi92 helfi92 Dec 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Slack, we need a change in the app repo which is not forked atm. It might be a bit extra work.

"description": "The Firebase Authenticaton component of the Firebase JS SDK.",
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
"main": "dist/node/index.js",
Expand Down