remove default stats logger to prevent error in docker

untoldone · Aug 29, 2017 · 360c0c3 · 360c0c3
1 parent 3014d7e
commit 360c0c3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/api/log.go b/api/log.go
@@ -18,7 +18,11 @@ func StatsLogger() *log.Logger {
 		logStyle := viper.GetString("statsLogger")
 		switch logStyle {
 		case "syslog":
-			statsWriter, _ = syslog.New(syslog.LOG_NOTICE, "bloomapi-stats")
+			var err error
+			statsWriter, err = syslog.New(syslog.LOG_NOTICE, "bloomapi-stats")
+			if err != nil {
+				log.Fatal("Error sending logs to syslog, check BloomAPI configuration")
+			}
 		case "stdout":
 			statsWriter = os.Stdout
 		default:

diff --git a/config.toml.sample b/config.toml.sample
@@ -4,5 +4,5 @@ searchHosts = [
 ]
 bloomapiPort = 3005
 yourchartUrl = "http://yourchart:3001"
-statsLogger = "syslog" # values can be: 'syslog' or 'stdout'
 generalLogger = "stdout"
+#statsLogger = "syslog" # values can be: 'syslog' or 'stdout', default is nothing
diff --git a/middleware/record_features.go b/middleware/record_features.go
@@ -17,6 +17,7 @@ func (s *RecordFeatures) ServeHTTP(rw http.ResponseWriter, r *http.Request, next
 	features := api.GetFeatures(r)
 	j, _ := json.Marshal(features)
 	featureJson := string(j)
-	api.StatsLogger().Println(featureJson)
+	stats := api.StatsLogger()
+	stats.Println(featureJson)
 	next(rw, r)
 }