Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parser handle marshalling an un marshalling of external files #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

shresthagrawal
Copy link
Member

@shresthagrawal shresthagrawal commented Mar 19, 2020

While reverse engineering I discovered two things:

  • There is a control code 1300 which stores the location of the disk(internal or external) from the root
  • everything that was previously considered as the system name was actually disk name.

Things to be done

  • Add test for un-marshalling of file-ref pointing to external disk
  • Add a new field isExternal to the file ref class, this will be useful while marshalling it
  • Change all the systemName to diskName
  • Make the un-marshalling recognise external disk, create appropriate location for such cases
  • Add test for marshalling of external disk
  • for the setLocation function, recognise if the new location is internal or external based on that change the fields isExternal, diskName
  • modify Marshall to handle external disk marshalling

@shresthagrawal shresthagrawal added bug Something isn't working enhancement New feature or request labels Mar 19, 2020
@shresthagrawal shresthagrawal self-assigned this Mar 19, 2020
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #17 into master will decrease coverage by 0.00%.
The diff coverage is 94.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   92.71%   92.70%   -0.01%     
==========================================
  Files          13       13              
  Lines         453      480      +27     
  Branches       41       43       +2     
==========================================
+ Hits          420      445      +25     
  Misses         15       15              
- Partials       18       20       +2     
Impacted Files Coverage Δ
lib/fileref/fileref.ts 96.55% <83.33%> (-3.45%) ⬇️
lib/fileref/fileref-data.ts 89.62% <95.12%> (+1.25%) ⬆️
test/fileref-test.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49412c...5825731. Read the comment docs.

Copy link
Contributor

@snvfk1n snvfk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

during testing, i've noticed that the resource path is somehow appended twice, for instance the file foo.mp3 will be moved to the resources/ directory, but internally in the Live project, it will we referenced as resources/foo.mp3/foo.mp3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants