-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make parser handle marshalling an un marshalling of external files #17
base: master
Are you sure you want to change the base?
Conversation
…g to external resource
0201283
to
5825731
Compare
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 92.71% 92.70% -0.01%
==========================================
Files 13 13
Lines 453 480 +27
Branches 41 43 +2
==========================================
+ Hits 420 445 +25
Misses 15 15
- Partials 18 20 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
during testing, i've noticed that the resource path is somehow appended twice, for instance the file foo.mp3
will be moved to the resources/
directory, but internally in the Live project, it will we referenced as resources/foo.mp3/foo.mp3
.
While reverse engineering I discovered two things:
1300
which stores the location of the disk(internal or external) from the rootThings to be done