Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4923 - Scrollbar/navbar with aesthetic scrolling to facilitate easier website navigation. #4976

Open
wants to merge 8 commits into
base: gh-pages
Choose a base branch
from

Conversation

KeshavSingal
Copy link

@KeshavSingal KeshavSingal commented Dec 9, 2024

Hey,
This PR closes issue #4923 raised by me.

Preview changes here: https://deploy-preview-4976--up-for-grabs-test-bench.netlify.app/#/

image

Changes Made

  • Added responsive navigation menu with smooth scrolling functionality
  • Implemented easy section navigation: Get Involved, Projects, Maintain a Project
  • Added testing file with 5 test cases:

Technical Details

  • Location: navbar.html in _includes folder
  • Features:
    • Smooth scrolling using requestAnimationFrame
    • No page refresh on navigation

Testing

  • All tests passing
  • ESLint issues resolved
  • Prettier formatting applied
  • Manually tested in local environment

Related Issue

Closes #4923

@shiftbot
Copy link
Contributor

shiftbot commented Dec 9, 2024

👋 I'm a robot checking the state of this pull request to save the human reviewers time. I don't see any changes under _data/projects/ so I don't have any feedback here.

As you make changes to this pull request, I'll re-run these checks.

@KeshavSingal KeshavSingal changed the title Issue 4923 Issue 4923 - Scrollbar/navbar with aesthetic scrolling to facilitate easier website navigation. Dec 9, 2024
Copy link

@TheGiraffe3 TheGiraffe3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a place to see this deployed?
See the page as it looks with these changes?

});
});
});
</script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</script>
</script>

@shiftkey
Copy link
Member

I'm not interested in this change because I feel it doesn't add much for two of the three buttons:

  • "I want to get involved!" - is directly below the nav bar, scrolls very slowly to move a short distance
  • "Projects" - is next, scrolls very slowly to move a short distance

So that leaves us with one button that scrolls a long distance. I feel that this is trying to solve the wrong problem and we should look at pagination or a different way to present a large list of projects.

Leaving this open for a bit but without more context I'm going to close this out...

@shiftkey shiftkey added has-questions Reviewer has outstanding questions about the pull request and removed needs-review labels Dec 30, 2024
@KeshavSingal
Copy link
Author

Ah I see, that makes sense. We can try pagination to solve the problem. One option/idea can be to add a scroll down button (just like how we have a scroll up button) to reach the "maintain a project section". We can remove the navbar.

@shiftkey shiftkey mentioned this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-questions Reviewer has outstanding questions about the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar or Scrollbar
4 participants