forked from vickonrails/next-starter-peacock
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix runtime errors by removing as
prop from Link
#200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dancing-dragon-b13f72 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ProchaLu
changed the title
Set
Use Next.js static rendering for Markdown content
Jan 7, 2025
metadataBase
URL in metadata generation
ProchaLu
changed the title
Use Next.js static rendering for Markdown content
Convert from static rendering to server-side rendering
Jan 7, 2025
As discussed offline:
|
ProchaLu
changed the title
Convert from static rendering to server-side rendering
Fix runtime errors by removing Jan 8, 2025
as
prop from Link
karlhorky
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197
Using both
href
andas
in theLink
component caused errors in the production build:This PR fixes the runtime errors during navigation in the production build by simplifying the
Link
component and removing theas
prop. Since Next.js v10.0.0,href
props pointing to a dynamic route are automatically resolved, making theas
prop redundant.Additionally this PR Set
metadataBase
URL in metadata generation to remove this warning during build.