Improving path registry #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jgmedina95
commented
Jan 4, 2024
Jgmedina95
commented
- Give value to the path_registry. Files names are now files id. Which are the ones the agent will use to use files inside tools (already implemented in simulations and cleaning tools)
- Improve ListRegistryPath as names are hardly self-explanatory, a description of each file is also included.
… tool to directly map pdb file into path registry with file id in new directory
making sure i merged
…gistry. b) improved the descriptions of the query for the modify script tool, and c) include the modified script into the path registry at the end of it
qcampbel
reviewed
Jan 4, 2024
| @@ -80,7 +79,7 @@ def make_all_tools( | |||
| CheckDirectoryFiles(), | |||
| # InstructionSummary(path_registry=path_instance), | |||
| ListRegistryPaths(path_registry=path_instance), | |||
| MapPath2Name(path_registry=path_instance), | |||
| # MapPath2Name(path_registry=path_instance), | |||
| Name2PDBTool(path_registry=path_instance), | |||
There was a problem hiding this comment.
you sure we want to remove that tool? suppose there are some files provided by users - just a thought
There was a problem hiding this comment.
good point, is just that the agent sometimes adds the same file more than once with the tool taking it made it work better for my examples.
SamCox822
reviewed
Jan 9, 2024
SamCox822
reviewed
Jan 10, 2024
SamCox822
reviewed
Jan 10, 2024
SamCox822
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.