-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#91: 대기방 리스트 화면 UI 구현 #119
Open
minjeongss
wants to merge
13
commits into
develop
Choose a base branch
from
feature/#91-waiting-room-list-ui
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+165
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
minjeongss
commented
Feb 5, 2025
Comment on lines
+5
to
+10
type RefreshIconProps = { onClick: () => void }; | ||
export const RefreshIcon = ({ onClick }: RefreshIconProps) => ( | ||
<div onClick={onClick}> | ||
<Image src={RefreshIconSrc} alt="Refresh Icon" /> | ||
</div> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next의 Image는 onClick 이벤트가 직접적으로 등록이 되지 않아서, 상위 컴포넌트로부터 props을 onClick을 받아 div에서 처리하도록 설정했습니다.
Image의 Icon을 활용하시는 분들에게 도움이 되지 않을까 싶어 comment 추가적으로 남깁니다. 😁
호스트 캐릭터 위치를 우측으로 변경했어요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
#91
📝 작업 내용
대기방 리스트 화면 UI를 구현했습니다. 구체적인 구현은 다음과 같습니다.
📸 스크린샷
💬 리뷰 요구사항