fix: only manager can see star rating

urfit-tech · Jan 9, 2025 · 0ed13f5 · 0ed13f5
1 parent 54106c0
commit 0ed13f5
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/src/components/sale/SalesLeadTable.tsx b/src/components/sale/SalesLeadTable.tsx
@@ -98,6 +98,7 @@ const StyledDelPhone = styled.p`
 const SalesLeadTable: React.VFC<{
   variant?: 'followed' | 'completed' | 'resubmission' | 'callbacked'
   manager: Manager
+  currentMemberIsManager: boolean
   leads: SalesLeadMember[]
   isLoading: boolean
   onRefetch: () => Promise<void>
@@ -116,6 +117,7 @@ const SalesLeadTable: React.VFC<{
 }> = ({
   variant,
   manager,
+  currentMemberIsManager,
   leads,
   onRefetch,
   onTableChange,
@@ -557,7 +559,7 @@ const SalesLeadTable: React.VFC<{
               </span>
             </a>
             <small>{lead?.email}</small>
-            {
+            {currentMemberIsManager ? (
               <div>
                 <StarRating
                   value={
@@ -580,7 +582,7 @@ const SalesLeadTable: React.VFC<{
                   }}
                 />
               </div>
-            }
+            ) : null}
             {hasFullNameProperty ? (
               <div className="d-flex align-items-center">
                 <p>{`${formatMessage(saleMessages.SalesLeadTable.memberFullName)}：`}</p>

diff --git a/src/components/sale/SalesLeadTabs.tsx b/src/components/sale/SalesLeadTabs.tsx
@@ -21,11 +21,19 @@ export type SelectedLeadStatusCategory = {
 
 const SalesLeadTabs: React.VFC<{
   manager: Manager
+  currentMemberIsManager: boolean
   activeKey: string
   selectedLeadStatusCategory: SelectedLeadStatusCategory | null
   onActiveKeyChanged: (activeKey: string) => void
   onSelectedLeadStatusCategoryChange: (selectedLeadStatusCategory: SelectedLeadStatusCategory | null) => void
-}> = ({ activeKey, manager, onActiveKeyChanged, selectedLeadStatusCategory, onSelectedLeadStatusCategoryChange }) => {
+}> = ({
+  activeKey,
+  manager,
+  currentMemberIsManager,
+  onActiveKeyChanged,
+  selectedLeadStatusCategory,
+  onSelectedLeadStatusCategoryChange,
+}) => {
   const { settings } = useApp()
   const [demoTabState, setDemoTabState] = useState<'INVITED' | 'PRESENTED' | null>(null)
   const [contactedTabState, setContactedTabState] = useState<'ANSWERED' | 'CONTACTED' | null>(null)
@@ -117,6 +125,7 @@ const SalesLeadTabs: React.VFC<{
     <SalesLeadTable
       title={salesLeadTableTitle}
       variant={salesLeadTableVariant}
+      currentMemberIsManager={currentMemberIsManager}
       manager={manager}
       selectedLeadStatusCategoryId={selectedLeadStatusCategory?.categoryId}
       onRefetch={async () => await refetch?.()}

diff --git a/src/pages/SalesLeadPage.tsx b/src/pages/SalesLeadPage.tsx
@@ -53,6 +53,8 @@ const SalesLeadPage: React.VFC = () => {
   const manager =
     managers.find(manager => manager.id === managerId) || (permissions.SALES_LEAD_ADMIN ? managers?.[0] : null)
 
+  const currentMemberIsManager = managers.some(manager => manager.id === currentMemberId)
+
   if (!enabledModules.sales || (!permissions.SALES_LEAD_ADMIN && !permissions.SALES_LEAD_NORMAL && !manager)) {
     return <ForbiddenPage />
   }
@@ -86,6 +88,7 @@ const SalesLeadPage: React.VFC = () => {
         <SalesLeadTabs
           activeKey={activeKey}
           manager={manager}
+          currentMemberIsManager={currentMemberIsManager}
           onActiveKeyChanged={setActiveKey}
           selectedLeadStatusCategory={selectedLeadStatusCategory}
           onSelectedLeadStatusCategoryChange={selectedLeadStatusCategory =>