🦖 fix clippy format string errors (#930)

* Cargo.lock

* Clippy

* Fmt

.rustfmt.toml

@@ -34,7 +34,7 @@ struct_field_align_threshold = 0
 enum_discrim_align_threshold = 0
 match_arm_blocks = true
 force_multiline_blocks = true # changed
-fn_args_layout = "Tall"
+fn_params_layout = "Tall"
 brace_style = "SameLineWhere"
 control_brace_style = "AlwaysSameLine"
 trailing_semicolon = false # changed

crates/build/build.rs

@@ -51,7 +51,7 @@ fn main() {
     match res {
         Ok(()) => std::process::exit(0),
         Err(err) => {
-            eprintln!("Encountered error: {:?}", err);
+            eprintln!("Encountered error: {err:?}");
             std::process::exit(1)
         }
     }

crates/build/src/crate_metadata.rs

@@ -193,7 +193,7 @@ fn get_cargo_toml_metadata(manifest_path: &ManifestPath) -> Result<ExtraMetadata
             .and_then(|v| v.as_str())
             .map(Url::parse)
             .transpose()
-            .context(format!("{} should be a valid URL", field_name))
+            .context(format!("{field_name} should be a valid URL"))
             .map_err(Into::into)
     };
 

crates/build/src/lib.rs

@@ -529,10 +529,9 @@ fn assert_compatible_ink_dependencies(
         let _ = util::invoke_cargo("tree", args, manifest_path.directory(), verbosity, vec![])
             .with_context(|| {
                 format!(
-                    "Mismatching versions of `{}` were found!\n\
+                    "Mismatching versions of `{dependency}` were found!\n\
                      Please ensure that your contract and your ink! dependencies use a compatible \
-                     version of this package.",
-                    dependency
+                     version of this package."
                 )
             })?;
     }
@@ -601,7 +600,7 @@ pub fn execute(args: ExecuteArgs) -> Result<BuildResult> {
             maybe_println!(
                 verbosity,
                 " {} {}",
-                format!("{}", steps).bold(),
+                format!("{steps}").bold(),
                 "Checking ink! linting rules".bright_green().bold()
             );
             steps.increment_current();
@@ -618,7 +617,7 @@ pub fn execute(args: ExecuteArgs) -> Result<BuildResult> {
         maybe_println!(
             verbosity,
             " {} {}",
-            format!("{}", build_steps).bold(),
+            format!("{build_steps}").bold(),
             "Building cargo project".bright_green().bold()
         );
         build_steps.increment_current();
@@ -635,7 +634,7 @@ pub fn execute(args: ExecuteArgs) -> Result<BuildResult> {
         maybe_println!(
             verbosity,
             " {} {}",
-            format!("{}", build_steps).bold(),
+            format!("{build_steps}").bold(),
             "Post processing wasm file".bright_green().bold()
         );
         build_steps.increment_current();
@@ -644,7 +643,7 @@ pub fn execute(args: ExecuteArgs) -> Result<BuildResult> {
         maybe_println!(
             verbosity,
             " {} {}",
-            format!("{}", build_steps).bold(),
+            format!("{build_steps}").bold(),
             "Optimizing wasm file".bright_green().bold()
         );
         build_steps.increment_current();
@@ -684,7 +683,7 @@ pub fn execute(args: ExecuteArgs) -> Result<BuildResult> {
             maybe_println!(
                 verbosity,
                 " {} {}",
-                format!("{}", build_steps).bold(),
+                format!("{build_steps}").bold(),
                 "Executing `cargo check`".bright_green().bold()
             );
             exec_cargo_for_wasm_target(

crates/build/src/metadata.rs

@@ -132,7 +132,7 @@ pub(crate) fn execute(
         maybe_println!(
             verbosity,
             " {} {}",
-            format!("{}", build_steps).bold(),
+            format!("{build_steps}").bold(),
             "Generating metadata".bright_green().bold()
         );
         let target_dir_arg = format!(
@@ -168,7 +168,7 @@ pub(crate) fn execute(
         maybe_println!(
             verbosity,
             " {} {}",
-            format!("{}", build_steps).bold(),
+            format!("{build_steps}").bold(),
             "Generating bundle".bright_green().bold()
         );
         let contents = serde_json::to_string(&metadata)?;

crates/build/src/new.rs

@@ -23,7 +23,6 @@ use std::{
         Cursor,
         Read,
         Seek,
-        SeekFrom,
         Write,
     },
     path::{
@@ -77,7 +76,7 @@ where
 fn unzip(template: &[u8], out_dir: PathBuf, name: Option<&str>) -> Result<()> {
     let mut cursor = Cursor::new(Vec::new());
     cursor.write_all(template)?;
-    cursor.seek(SeekFrom::Start(0))?;
+    cursor.rewind()?;
 
     let mut archive = zip::ZipArchive::new(cursor)?;