Skip to content

Commit

Permalink
Move sandbox version to package instead of workspace
Browse files Browse the repository at this point in the history
  • Loading branch information
pgherveou committed Mar 19, 2024
1 parent 62b76b7 commit 1175740
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ ink = { version = "=5.0.0", path = "crates/ink", default-features = false }
ink_allocator = { version = "=5.0.0", path = "crates/allocator", default-features = false }
ink_codegen = { version = "=5.0.0", path = "crates/ink/codegen", default-features = false }
ink_e2e_macro = { version = "=5.0.0", path = "crates/e2e/macro", default-features = false }
ink_sandbox = { version = "=5.0.0", path = "crates/e2e/sandbox", default-features = false }
ink_engine = { version = "=5.0.0", path = "crates/engine", default-features = false }
ink_env = { version = "=5.0.0", path = "crates/env", default-features = false }
ink_ir = { version = "=5.0.0", path = "crates/ink/ir", default-features = false }
Expand Down
5 changes: 3 additions & 2 deletions RELEASES_CHECKLIST.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ in the future.
- Release `cargo-contract` crates.
- Request update of `drink` client, which depends on the `cargo-contract` crates.
- Release `ink_e2e`.
2. Do a dry run with `cargo release [new_version] -v --no-tag --no-push`
2. Do a dry run with `cargo release [new_version] -v --no-tag --no-push --exclude ink_sandbox`
- `[new_version]` should be the **exact** SemVer compatible version you are attempting
to release e.g. `5.0.0`
- It is possible to supply a SemVer level here e.g. `major`, `minor`, `patch` or
Expand All @@ -69,6 +69,7 @@ in the future.
is not necessary.
- We don't want `cargo-release` to create any releases or push any code, we'll do
that manually once we've actually published to `crates.io`.
- Note that `ink_sandbox` is released separetly and is excluded via the `--exclude` flag.

This comment has been minimized.

Copy link
@ascjones

ascjones Mar 19, 2024

Collaborator

We could still include ink_sandbox in the ink release (sometimes even it will be necessary because e2e depends on it). The difference is that it can be released on its own independent of the other crates, and therefore has its own version number.

3. Check the output of the dry run:
- Does not show any automatic bumping of crate versions.
- Runs without error.
Expand All @@ -82,7 +83,7 @@ in the future.
`master` during the release.
- The above are to ensure that the bundled code pushed to crates.io is the same as
the tagged release on GitHub.
5. Publish with `cargo release [new_version] -v --no-tag --no-push --execute`
5. Publish with `cargo release [new_version] -v --no-tag --no-push --execute --exclude ink_sandbox`
- Ensure the same `[new_version]` as the dry run, which should be the **exact** SemVer
compatible version you are attempting to release e.g. `4.0.0-alpha.3`.
- We add the grace period since crates depend on one another.
Expand Down
2 changes: 1 addition & 1 deletion crates/e2e/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ ink_primitives = { workspace = true, default-features = true }

cargo_metadata = { workspace = true }
contract-build = { workspace = true }
ink_sandbox = { workspace = true, optional = true }
ink_sandbox = { path = "./sandbox", optional = true }
pallet-contracts-mock-network = { workspace = true, optional = true }
funty = { workspace = true }
impl-serde = { workspace = true }
Expand Down
2 changes: 1 addition & 1 deletion crates/e2e/sandbox/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "ink_sandbox"
version.workspace = true
version = "5.0.0"
authors = ["Cardinal Cryptography", "Parity Technologies <[email protected]>"]
edition.workspace = true
license.workspace = true
Expand Down

0 comments on commit 1175740

Please sign in to comment.