Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Dial Templates default timeout #8

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

joele89
Copy link
Contributor

@joele89 joele89 commented Oct 27, 2024

No description provided.

@gareth-palmer
Copy link
Contributor

The text should say "if you do not specify a dial template" instead of "if you don't create a Dial Template" as one may be created but not specified.

I wonder if that 15s timeout is <offhookToFirstDigitTimer>, that should be checked.

The documentation doesn't use an italicised "Important" for notable information, instead it uses a bold "Note".

@gareth-palmer gareth-palmer self-assigned this Oct 28, 2024
@gareth-palmer gareth-palmer added the needs work This change needs additional work label Oct 28, 2024
@joele89
Copy link
Contributor Author

joele89 commented Oct 28, 2024

Understood, will make the adjustments in the text.

I will test changes to <offhookToFirstDigitTimer>, however the text suggests that it's a different part of the process.

@joele89
Copy link
Contributor Author

joele89 commented Oct 28, 2024

I have also added a similar note to the Dial Templates page

@gareth-palmer
Copy link
Contributor

Did <offhookToFirstDigitTimer> change the behaviour? Options that relate to dialing both having a value of 15s might be more than coincidental

Revert the change to dial-templates.html as I only want the note on the SEPMAC.cnf.xml for now.

Also, the ':' shouldn't be bolded, ie: <b>Note</b>:.

@joele89
Copy link
Contributor Author

joele89 commented Oct 29, 2024

I have confirmed that the <offhookToFirstDigitTimer> does not impact the wait time associated with dial templates (offhook is before dialing, dial templates set after dialing wait).

@gareth-palmer
Copy link
Contributor

Contractions (don't, isn't, wasn't etc.) are to be avoided in formal text.
Dial Template does not need to be capitalized.
Have the text exactly be:

default timeout is 15 seconds if you don not specify a dial template.

@gareth-palmer gareth-palmer merged commit 1af34ef into usecallmanagernz:master Oct 30, 2024
1 check passed
@joele89 joele89 deleted the patch-2 branch October 30, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work This change needs additional work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants