Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: additional prebackuppod changes #246

Merged
merged 6 commits into from
Oct 26, 2023
Merged

fix: additional prebackuppod changes #246

merged 6 commits into from
Oct 26, 2023

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Oct 25, 2023 •
edited
Loading

Corrects an issue where the variable name used for the readreplicas was wrong

tobybellwood
tobybellwood approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested working.

Straightforward change - renaming the variable correctly.

@shreddedbacon shreddedbacon changed the title fix: use the right variable name for prebackuppod readreplicas fix: additional prebackuppod changes Oct 26, 2023
tobybellwood
tobybellwood approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy with this - retains previous functionality, with the added bonus of using the correct variable

@shreddedbacon shreddedbacon merged commit 7ac98ae into main Oct 26, 2023
2 checks passed
@shreddedbacon shreddedbacon deleted the prebackuppod-fix branch October 26, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood