refactor: only generate schedules if resource types have backups

cmd/template_backups_test.go

@@ -19,6 +19,7 @@ func TestBackupTemplateGeneration(t *testing.T) {
 		args         testdata.TestData
 		templatePath string
 		want         string
+		emptyDir     bool // if no templates are generated, then there will be a .gitkeep file in there
 		wantErr      bool
 	}{
 		{
@@ -188,6 +189,27 @@ func TestBackupTemplateGeneration(t *testing.T) {
 			templatePath: "testdata/output",
 			want:         "../internal/testdata/complex/backup-templates/backup-2",
 		},
+		{
+			name: "test9 - nothing to backup so no schedule",
+			args: testdata.GetSeedData(
+				testdata.TestData{
+					ProjectName:     "example-project",
+					EnvironmentName: "main",
+					Branch:          "main",
+					K8UPVersion:     "v2",
+					LagoonYAML:      "../internal/testdata/node/lagoon.nostorage.yml",
+					ProjectVariables: []lagoon.EnvironmentVariable{
+						{
+							Name:  "LAGOON_FEATURE_FLAG_IMAGECACHE_REGISTRY",
+							Value: "imagecache.example.com",
+							Scope: "global",
+						},
+					},
+				}, true),
+			templatePath: "testdata/output",
+			emptyDir:     true,
+			want:         "../internal/testdata/node/backup-templates/backup-7",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -221,7 +243,16 @@ func TestBackupTemplateGeneration(t *testing.T) {
 			if err != nil {
 				t.Errorf("couldn't read directory %v: %v", tt.want, err)
 			}
-			if len(files) != len(results) {
+			resultSize := 0
+			if !tt.emptyDir {
+				results, err = ioutil.ReadDir(tt.want)
+				if err != nil {
+					t.Errorf("couldn't read directory %v: %v", tt.want, err)
+				}
+				// .gitkeep file needs to be subtracted to equal 0
+				resultSize = len(results)
+			}
+			if len(files) != resultSize {
 				for _, f := range files {
 					f1, err := os.ReadFile(fmt.Sprintf("%s/%s", savedTemplates, f.Name()))
 					if err != nil {

internal/generator/buildvalues.go

@@ -48,6 +48,7 @@ type BuildValues struct {
 	TaskScaleMaxIterations        int                         `json:"taskScaleMaxIterations"`
 	TaskScaleWaitTime             int                         `json:"taskScaleWaitTime"`
 	ImageCache                    string                      `json:"imageCache"`
+	BackupsEnabled                bool                        `json:"backupsEnabled"`
 	DefaultBackupSchedule         string                      `json:"defaultBackupSchedule"`
 	DBaaSClient                   *dbaasclient.Client         `json:"-"`
 }
@@ -91,6 +92,7 @@ type ServiceValues struct {
 	CronjobTolerations            *[]corev1.Toleration     `json:"cronjobTolerations"`
 	CronjobAffinity               *corev1.Affinity         `json:"cronjobAffinity"`
 	DBaasReadReplica              bool                     `json:"dBaasReadReplica"`
+	BackupsEnabled                bool                     `json:"backupsEnabled"`
 }
 
 // CronjobValues is the values for cronjobs

internal/generator/services.go

@@ -35,6 +35,26 @@ var supportedAutogeneratedTypes = []string{
 	"python",
 }
 
+// these are lagoon types that come with resources requiring backups
+var typesWithBackups = []string{
+	"basic-persistent",
+	"node-persistent",
+	"nginx-php-persistent",
+	"python-persistent",
+	"varnish-persistent",
+	"redis-persistent",
+	"solr",
+	"elasticsearch",
+	"opensearch",
+	"rabbitmq",
+	"mongodb-dbaas",
+	"mariadb-dbaas",
+	"postgres-dbaas",
+	"mariadb-single",
+	"postgres-single",
+	"mongodb-single",
+}
+
 // just some default values for services
 var defaultServiceValues = map[string]map[string]string{
 	"elasticsearch": map[string]string{
@@ -102,6 +122,9 @@ func generateServicesFromDockerCompose(
 				if err != nil {
 					return err
 				}
+				if cService.BackupsEnabled {
+					buildValues.BackupsEnabled = true
+				}
 				buildValues.Services = append(buildValues.Services, cService)
 			}
 		}
@@ -311,6 +334,13 @@ func composeToServiceValues(
 			autogenTLSAcmeEnabled = false
 		}
 
+		// check if this service is one that supports backups
+		backupsEnabled := false
+		if helpers.Contains(typesWithBackups, lagoonType) {
+			backupsEnabled = true
+
+		}
+
 		// create the service values
 		cService := ServiceValues{
 			Name:                       composeService,
@@ -322,6 +352,7 @@ func composeToServiceValues(
 			PersistentVolumePath:       servicePersistentPath,
 			PersistentVolumeName:       servicePersistentName,
 			PersistentVolumeSize:       servicePersistentSize,
+			BackupsEnabled:             backupsEnabled,
 		}
 		// check if the service has a service port override (this only applies to basic(-persistent))
 		servicePortOverride := lagoon.CheckServiceLagoonLabel(composeServiceValues.Labels, "lagoon.service.port")

internal/generator/services_test.go

@@ -115,6 +115,7 @@ func Test_composeToServiceValues(t *testing.T) {
 				Type:                       "nginx-php-persistent",
 				AutogeneratedRoutesEnabled: true,
 				AutogeneratedRoutesTLSAcme: true,
+				BackupsEnabled:             true,
 			},
 		},
 		{
@@ -147,6 +148,7 @@ func Test_composeToServiceValues(t *testing.T) {
 				Type:                       "nginx-php-persistent",
 				AutogeneratedRoutesEnabled: true,
 				AutogeneratedRoutesTLSAcme: true,
+				BackupsEnabled:             true,
 			},
 		},
 		{
@@ -348,6 +350,7 @@ func Test_composeToServiceValues(t *testing.T) {
 				AutogeneratedRoutesEnabled: false,
 				AutogeneratedRoutesTLSAcme: false,
 				DBaaSEnvironment:           "development",
+				BackupsEnabled:             true,
 			},
 		},
 		{
@@ -391,6 +394,7 @@ func Test_composeToServiceValues(t *testing.T) {
 				AutogeneratedRoutesEnabled: false,
 				AutogeneratedRoutesTLSAcme: false,
 				DBaaSEnvironment:           "development2",
+				BackupsEnabled:             true,
 			},
 		},
 		{
@@ -429,6 +433,7 @@ func Test_composeToServiceValues(t *testing.T) {
 				AutogeneratedRoutesEnabled: false,
 				AutogeneratedRoutesTLSAcme: false,
 				DBaaSEnvironment:           "development",
+				BackupsEnabled:             true,
 			},
 		},
 		{