fix: lagoon.persistent.name override checks #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
changed the title
shreddedbacon
force-pushed
the
fix-persistent-name
branch
from
545b329 to
ec8ec00
Compare
tobybellwood
approved these changes
Oct 21, 2024
shreddedbacon
force-pushed
the
fix-persistent-name
branch
from
ec8ec00 to
ae66e49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #289 when we changed from helm to go for service templating services, a case was missed where the
lagoon.persistent.namemay be used on services that aren'tnginx-php-persistentfor the default volume created by a service type. This corrects that case by verifying if the services provide or share a persistent volume or that volume name differs to the one that would be provided by the service.closes #382