Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle page view for SPA #321

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Handle page view for SPA #321

merged 3 commits into from
Dec 6, 2023

Conversation

chuanlin2018
Copy link
Collaborator

Google Analytics is not notified when we route to a page inside SPA. To fix that, we subscribe to the Angular router inside the app.component.ts file and send the new routes to Google Analytics.

PDR does not route to a page inside the app so it does not has this issue so far. But I added this piece of code here as a standard GA4 implementation.

@chuanlin2018 chuanlin2018 requested a review from RayPlante July 11, 2023 16:53
Copy link
Collaborator

@RayPlante RayPlante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on testdata (as part of oar-docker 1.11.0rc2); no discernable issues on browser-side, and no errors appearing on the server-side.

@RayPlante RayPlante merged commit bfaba15 into integration Dec 6, 2023
4 checks passed
@RayPlante RayPlante deleted the feature/ODD1091-ga4-fix branch December 6, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants