Provide full support for unicode in filenames #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta to test support.
|
Tested via hot fix on oardata to support mds2-2775. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes support for unicode characters in submitted dataset filenames under the python2.7. This includes pulling in a fix to oar-metadata's
jq/urldecode.jqscript which establishes the names of dataset files. Supporting unicode on Python 2.7 is tricky since unicode is not the default string type. A key part for the fix is updating thepdrtestdocker image to set python's default encoding to 'UTF-8'; this will also have to be applied at the oar-docker level. A number of tests (but not all) were updated to ensure support for unicode is working.Also fixed in this PR: