Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve CVS-408 #994

Merged
merged 2 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
<div>UWNetID: <strong>{{login_id}}</strong>
{{#if can_access_canvas}}
<i class="fa fa-check-circle-o success" title="This UWNetid is allowed to access Canvas"></i>
{{#if can_masquerade_as_user}}
&nbsp;&nbsp;&nbsp;<a class="js-sws-person" href="https://canvas.uw.edu/users/{{id}}/masquerade" target="_blank" title="Masquerade as {{name}} in Canvas">Masquerade</a>
{{/if}}
{{else}}
<i class="fa fa-ban failure" title="This UWNetid is NOT allowed to access Canvas"></i>
{{/if}}
Expand Down
6 changes: 6 additions & 0 deletions sis_provisioner/test/views/test_admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ def test_can_manage_external_tools(self):
def test_can_manage_course_expirations(self):
self.assertTrue(AdminView.can_manage_course_expirations(self.request))

def test_can_masquerade_as_user(self):
self.assertTrue(AdminView.can_masquerade_as_user(
self.request, 'jbothell'))
self.assertFalse(AdminView.can_masquerade_as_user(
self.request, 'javerage'))


class RestDispatchTest(TestCase):
def test_error_response(self):
Expand Down
7 changes: 7 additions & 0 deletions sis_provisioner/views/admin.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@ def can_merge_users(request):
def can_create_user_course(request):
return is_member_of_group(request, settings.RESTCLIENTS_ADMIN_GROUP)

@staticmethod
def can_masquerade_as_user(request, as_user):
return (
get_user(request) != as_user and
not Admin.objects.is_account_admin(as_user) and
is_member_of_group(request, settings.RESTCLIENTS_ADMIN_GROUP))


class ImportStatus(AdminView):
template_name = 'canvas_admin/status.html'
Expand Down
5 changes: 5 additions & 0 deletions sis_provisioner/views/user.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ def response_for_person(self, person):
'queue_id': None,
'can_merge_users': False,
'can_create_user_course': False,
'can_masquerade_as_user': False,
'enrollment_url': None,
'canvas_users': [],
}
Expand Down Expand Up @@ -148,6 +149,10 @@ def response_for_person(self, person):
if (self.can_create_user_course(self.request) and
response['can_access_canvas']):
response['can_create_user_course'] = True

if (self.can_masquerade_as_user(
self.request, response['canvas_users'][0]['login_id'])):
response['can_masquerade_as_user'] = True
else:
response['can_merge_users'] = self.can_merge_users(self.request)

Expand Down