Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change invited admin user password on first login #58

Merged
merged 9 commits into from
Oct 3, 2024

Conversation

ji-mmyliu
Copy link
Collaborator

@ji-mmyliu ji-mmyliu commented Jul 31, 2024

Notion ticket link

Change Password on First Login for Invited User

Implementation description

  • Used Firebase's REST API to change password using user's access token.
  • Split logic for change password and updating user status into two separate endpoints.

Steps to test

  1. Post the invite admin endpoint in the backend using Postman and a manually obtained admin access token to invite a new admin user
  2. Verify and login using the new credentials
  3. Choose a new password and check that your user is now Active.

What should reviewers focus on?

  • The process flow and potential security issues.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@ji-mmyliu ji-mmyliu requested a review from carolynzhang18 July 31, 2024 03:30
@ji-mmyliu ji-mmyliu force-pushed the jimmy/change-password-first-login branch from 92946e8 to dc9a336 Compare July 31, 2024 03:38
@carolynzhang18
Copy link
Collaborator

WORKS SUPER NICE I LOVE IT!!! 🤩

@carolynzhang18
Copy link
Collaborator

One thing I just thought of - let's say I'm logging in for the first time, I reach the "change your password" page, and then before changing my password I close the tab (so I didn't actually fill in the form).
Next time I open the app, I'm still on the "change your password" page. Do you think that's an issue? I thiiink it's ok but we can discuss at first meeting :)

Copy link
Collaborator

@carolynzhang18 carolynzhang18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome awesome stuff, thanks for your hard work with this one!!! 😎
left a few minor comments but everything else looks good to me!

docker-compose.yml Outdated Show resolved Hide resolved
frontend/src/components/pages/CreatePasswordPage.tsx Outdated Show resolved Hide resolved
frontend/src/components/pages/CreatePasswordPage.tsx Outdated Show resolved Hide resolved
backend/services/implementations/authService.ts Outdated Show resolved Hide resolved
backend/package.json Outdated Show resolved Hide resolved
@ji-mmyliu ji-mmyliu force-pushed the jimmy/change-password-first-login branch from e34c66a to 7ddb407 Compare September 24, 2024 02:59
Copy link
Collaborator

@mxc-maggiechen mxc-maggiechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@ji-mmyliu ji-mmyliu merged commit 4abcb49 into main Oct 3, 2024
1 check passed
@ji-mmyliu ji-mmyliu deleted the jimmy/change-password-first-login branch October 3, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants