-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help request notifications/fixed #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngl i dont what is exactly the problem is but i do get rate limited on help request page and just going between individual help request page and the view all help request page (which is a likely use case). Maybe some caching is needed? |
carolynzhang18
approved these changes
Sep 23, 2024
…d to fix socket being null on frontend in context
carolynzhang18
force-pushed
the
help-request-notifications/fixed
branch
from
September 23, 2024 21:40
a256c8a
to
6ec96a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Ticket Name
Implementation description
Steps to test
I might add a video about doing this cuz these steps are too hard for me to understand too ngl
What should reviewers focus on?
ngl this is too long so whoever is reviewing this have fun. Most of the bad code is on the backend though
I am prolly very inconsistent so like tell me where i should change variable names and stuff
In notification router, there is a /test route. That shouldn't exist but it's only there since I haven't figured out how to fix an error related to importing mongoose models in the correct order. Dont worry abt testing that.
Checklist