Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF display POC #78

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

PDF display POC #78

wants to merge 2 commits into from

Conversation

98ZhaoJeffrey
Copy link
Collaborator

Notion ticket link

Ticket Name

Implementation description

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@98ZhaoJeffrey 98ZhaoJeffrey added the DO_NOT_MERGE don't merge this branch label Nov 14, 2024
@98ZhaoJeffrey
Copy link
Collaborator Author

react pdf has a weird design choice where you cant see height={100%} but instead must pass in the pixel height. This would work if we had a way of forcing it to match the parent container's height everytime but when fullscreening, it doesn't become 100% height everytime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO_NOT_MERGE don't merge this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant