-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Bazel 8.0.0 #3035
base: main
Are you sure you want to change the base?
Upgrade to Bazel 8.0.0 #3035
Changes from all commits
2a9eecf
0c2d795
8180488
534d0ed
0a3fcb2
3b7a19c
4d318ef
f51c249
3e3de12
58071b1
25e88fa
88f68f8
d72e1a8
f79bd2b
1a66821
6536db2
d8467fa
2e3a067
5ee0ce0
36d49ca
558c6e3
718f096
684b59d
c0b886e
f1fea0b
b058717
c7350d8
d6f17b8
d16e5e3
b612526
de99630
0eb3c36
91022ff
e458d31
a0bc98e
66733d5
229a2f4
d605a2f
fe71f56
f5e9584
28b0dcb
f9b2808
4b0e979
d8bbe96
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
7.4.1 | ||
8.0.1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,8 +26,8 @@ pr: | |
variables: | ||
OPENBLAS_VERSION : 'v0.3.27' | ||
TBB_VERSION : 'v2021.10.0' | ||
VM_IMAGE : 'ubuntu-22.04' | ||
SYSROOT_OS: 'jammy' | ||
VM_IMAGE : 'ubuntu-24.04' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does it make sense to update just bazel public ci step? just a question |
||
SYSROOT_OS: 'noble' | ||
WINDOWS_BASEKIT_URL: 'https://registrationcenter-download.intel.com/akdlm/IRC_NAS/b380d914-366b-4b77-a74a-05e3c38b3514/intel-oneapi-base-toolkit-2025.0.0.882_offline.exe' | ||
WINDOWS_DPCPP_COMPONENTS: 'intel.oneapi.win.mkl.devel:intel.oneapi.win.tbb.devel' | ||
|
||
|
@@ -474,7 +474,7 @@ jobs: | |
# Display oneDAL build configuration | ||
bazel build @config//:dump | ||
echo | ||
cat bazel-bin/external/config/config.json | ||
cat bazel-bin/external/+_repo_rules+config/config.json | ||
echo | ||
displayName: 'bazel-configure' | ||
- script: | | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,135 @@ | ||
# | ||
# Copyright contributors to the oneDAL project | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
module(name = "onedal") | ||
|
||
bazel_dep(name = "platforms", version = "0.0.10") | ||
bazel_dep(name = "bazel_skylib", version = "1.7.1") | ||
bazel_dep(name = "rules_cc", version = "0.0.17") | ||
|
||
KateBlueSky marked this conversation as resolved.
Show resolved
Hide resolved
|
||
declare_onedal_config = use_repo_rule("@onedal//dev/bazel/config:config.bzl", "declare_onedal_config") | ||
declare_onedal_config(name = "config",) | ||
|
||
sh_config_ext = use_extension("@onedal//dev/bazel/toolchains:cc_toolchain_extension.bzl", "cc_toolchain_extension") | ||
use_repo(sh_config_ext, "onedal_cc_toolchain") | ||
register_toolchains("@{}//:all".format("onedal_cc_toolchain")) | ||
|
||
|
||
extra_toolchain_ext = use_extension("@onedal//dev/bazel/toolchains:extra_toolchain_extension.bzl", "onedal_extra_toolchain_extension") | ||
use_repo(extra_toolchain_ext, "onedal_extra_toolchain") | ||
register_toolchains("@{}//:all".format("onedal_extra_toolchain")) | ||
|
||
|
||
opencl_repo = use_repo_rule("@onedal//dev/bazel/deps:opencl.bzl", "opencl_repo") | ||
opencl_repo(name = "opencl") | ||
|
||
openblas_repo = use_repo_rule("@onedal//dev/bazel/deps:openblas.bzl", "openblas_repo") | ||
openblas_repo(name = "openblas", root_env_var = "OPENBLASROOT",) | ||
|
||
tbb_repo = use_repo_rule("@onedal//dev/bazel/deps:tbb.bzl", "tbb_repo") | ||
tbb_repo( | ||
name = "tbb", | ||
root_env_var = "TBBROOT", | ||
urls = [ | ||
"https://files.pythonhosted.org/packages/93/4b/2e29f4266be5a66f21fc2dadcde48f9acea86119d6fb1bb2d2a451222ff7/tbb-2022.0.0-py2.py3-none-manylinux_2_28_x86_64.whl", | ||
"https://files.pythonhosted.org/packages/ff/8c/1eb1f856a7a328242d524f1bf64f2a212d46ce5651168e7c8bc7aeaf0f44/tbb_devel-2022.0.0-py2.py3-none-manylinux_2_28_x86_64.whl", | ||
], | ||
sha256s = [ | ||
"15a15a4e3ea4c3f3198bdb3c55fac75c589e15ed2ad0bbb080900d355c5b017e", | ||
"474e4ed1dce2efeea1d3652e295a97713df5d0ed854c937ee7d0464c38353c36", | ||
], | ||
strip_prefixes = [ | ||
"tbb-2022.0.0.data/data", | ||
"tbb_devel-2022.0.0.data/data", | ||
] | ||
) | ||
|
||
mpi_repo = use_repo_rule("@onedal//dev/bazel/deps:mpi.bzl", "mpi_repo") | ||
mpi_repo( | ||
name = "mpi", | ||
root_env_var = "MPIROOT", | ||
urls = [ | ||
"https://files.pythonhosted.org/packages/0a/7c/0f4de62a3463e4ebcf232352b231427f3b34c6a0a1b102a94da3246cad76/impi_rt-2021.14.0-py2.py3-none-manylinux_2_28_x86_64.whl", | ||
"https://files.pythonhosted.org/packages/10/9f/4ee3244c078b9e9e8f65ec51760e7a6e52988abba92a285ab8b0c4dbafff/impi_devel-2021.14.0-py2.py3-none-manylinux_2_28_x86_64.whl", | ||
], | ||
sha256s = [ | ||
"f06ac9eba3de9609fb257d714e3041f82334ccfe27a9bec0f90007d6381dd52e", | ||
"6a6ec66719ac4884a40a0504f4f186f51ee4169bece5f4486c31138ed6bcc87d", | ||
], | ||
strip_prefixes = [ | ||
"impi_rt-2021.14.0.data/data", | ||
"impi_devel-2021.14.0.data/data", | ||
] | ||
) | ||
|
||
ccl_repo = use_repo_rule("@onedal//dev/bazel/deps:ccl.bzl", "ccl_repo") | ||
ccl_repo( | ||
name = "ccl", | ||
root_env_var = "CCL_ROOT", | ||
urls = [ | ||
"https://files.pythonhosted.org/packages/c4/34/84fcf891faabfcd88e1e054a9268cdbefac8c22ab37d7eea2d9a3bda0f52/oneccl_devel-2021.14.0-py2.py3-none-manylinux_2_28_x86_64.whl", | ||
], | ||
sha256s = [ | ||
"580641c9d296b673d225ed3ca740b3356d7408a5c792de596a8836fde7d6c79e", | ||
], | ||
strip_prefixes = [ | ||
"oneccl_devel-2021.14.0.data/data", | ||
] | ||
) | ||
|
||
mkl_repo = use_repo_rule("@onedal//dev/bazel/deps:mkl.bzl", "mkl_repo") | ||
mkl_repo( | ||
name = "mkl", | ||
root_env_var = "MKLROOT", | ||
urls = [ | ||
"https://files.pythonhosted.org/packages/95/d8/76f53cde7c1df06fcd153b4f6fdf0516aafbfc3239ba8d5a8c354e20bbb2/mkl_static-2025.0.0-py2.py3-none-manylinux_2_28_x86_64.whl", | ||
"https://files.pythonhosted.org/packages/b1/91/b76ab204c03f90d5ce008ba7cf6efd77168059866e96b70277fec959b940/mkl_include-2025.0.0-py2.py3-none-manylinux_2_28_x86_64.whl", | ||
"https://files.pythonhosted.org/packages/b8/d7/ea82194db165d83e22dfedee4d45423477441202e2c321b9e96809d36e63/mkl_devel_dpcpp-2025.0.0-py2.py3-none-manylinux_2_28_x86_64.whl", | ||
], | ||
sha256s = [ | ||
"706f92fcd6e00cc94155097a87528da52b4c3dda4616c8c334963251773a0d13", | ||
"cf19e274bdd1449ef7285671576c545510bebff669363ee1926779192f618cdd", | ||
"455281a590920fb58628dbc06ac007f2618c7315e4c04748c2a1b62efa01afb3", | ||
], | ||
strip_prefixes = [ | ||
"mkl_static-2025.0.0.data/data", | ||
"mkl_include-2025.0.0.data/data", | ||
"mkl_devel_dpcpp-2025.0.0.data/data", | ||
], | ||
) | ||
|
||
onedal_repo = use_repo_rule("@onedal//dev/bazel/deps:onedal.bzl", "onedal_repo") | ||
onedal_repo( | ||
name = "onedal_release", | ||
root_env_var = "DALROOT", | ||
) | ||
|
||
http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | ||
|
||
http_archive( | ||
name = "catch2", | ||
url = "https://github.com/catchorg/Catch2/archive/v3.8.0.tar.gz", | ||
sha256 = "1ab2de20460d4641553addfdfe6acd4109d871d5531f8f519a52ea4926303087", | ||
strip_prefix = "Catch2-3.8.0", | ||
) | ||
|
||
http_archive( | ||
name = "fmt", | ||
url = "https://github.com/fmtlib/fmt/archive/11.1.2.tar.gz", | ||
sha256 = "d8773cf062cc806d4dd4df658111f15ba7a2c9c65db5084d2491696828b1eb97", | ||
strip_prefix = "fmt-11.1.2", | ||
build_file = "@onedal//dev/bazel/deps:fmt.tpl.BUILD", | ||
) |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,6 +60,8 @@ def get_default_flags(arch_id, os_id, compiler_id, category = "common"): | |
flags = flags + ["-Wno-unused-command-line-argument"] | ||
if compiler_id == "gcc" or compiler_id == "icpx": | ||
flags = flags + ["-Wno-gnu-zero-variadic-macro-arguments"] | ||
if compiler_id == "gcc": | ||
flags = flags + ["-Wno-dangling-reference"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Just noticed that you added it in the description. Still, would be useful to attach the full warning log just in case. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it necessary to add the same flag for icx? |
||
if compiler_id not in ["icx", "icpx"]: | ||
flags = flags + ["-fno-strict-overflow"] | ||
return flags | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# | ||
# Copyright contributors to the oneDAL project | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
load("@onedal//dev/bazel/toolchains:cc_toolchain.bzl", "onedal_cc_toolchain") | ||
|
||
cc_toolchain_extension = module_extension( | ||
implementation = lambda ctx: onedal_cc_toolchain(name = "onedal_cc_toolchain"), | ||
) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# | ||
# Copyright contributors to the oneDAL project | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
|
||
load("@onedal//dev/bazel/toolchains:extra_toolchain.bzl", "onedal_extra_toolchain") | ||
|
||
onedal_extra_toolchain_extension = module_extension( | ||
implementation = lambda ctx: onedal_extra_toolchain(name = "onedal_extra_toolchain"), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs on this aren't super clear to me - what would happen if this flag is not added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Bazel 8.0, the flag --incompatible_disallow_empty_glob will default to true. This means that the allow_empty argument defaults to False on all glob calls. In Bazel 7.0 --incompatible_disallow_empty_glob defaulted to False and the allow_empty argument defaults to True on all glob calls. Some of the glob calls in the project return empty list, so in bazel 8.0 those glob calls that return empty list error out without setting allow_empty set to true.