Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix min, max and sum_squares computations in low order moments #3047

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

Vika-F
Copy link
Contributor

@Vika-F Vika-F commented Jan 17, 2025

Adjust number of iterations in a loop to fix "min", "max" and "sum_squares" computations.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

Performance

Performance of low order moments computations might be affected by this change. Because previously part of the computations was skipped producing incorrect results.

@Vika-F
Copy link
Contributor Author

Vika-F commented Jan 17, 2025

/intelci: run

@Vika-F Vika-F marked this pull request as ready for review January 20, 2025 08:41
@Vika-F Vika-F merged commit 5d3d62c into uxlfoundation:main Jan 20, 2025
23 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants