Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onedpl][ranges][doc] + Range-based API description #1596

Merged
merged 38 commits into from
Sep 17, 2024
Merged

[onedpl][ranges][doc] + Range-based API description #1596

merged 38 commits into from
Sep 17, 2024

Conversation

MikeDvorskiy
Copy link
Contributor

[onedpl][doc] + Range-based API description

@MikeDvorskiy MikeDvorskiy marked this pull request as draft May 21, 2024 11:01
@MikeDvorskiy MikeDvorskiy requested review from dcbenito and akukanov May 21, 2024 16:39
@MikeDvorskiy MikeDvorskiy marked this pull request as ready for review June 3, 2024 10:22
@MikeDvorskiy MikeDvorskiy changed the title [onedpl][doc] + Range-based API description [onedpl][ranges][doc] + Range-based API description Jun 4, 2024
dcbenito
dcbenito reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@dcbenito dcbenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left my review comments; minor changes, but generally looks good.

documentation/library_guide/parallel_api/pass_data_algorithms.rst Outdated Show resolved Hide resolved
documentation/library_guide/parallel_api/pass_data_algorithms.rst Outdated Show resolved Hide resolved
documentation/library_guide/parallel_api/pass_data_algorithms.rst Outdated Show resolved Hide resolved
documentation/library_guide/parallel_api/range_based_api.rst Outdated Show resolved Hide resolved
documentation/library_guide/parallel_api/range_based_api.rst Outdated Show resolved Hide resolved
documentation/library_guide/parallel_api/range_based_api.rst Outdated Show resolved Hide resolved
documentation/library_guide/parallel_api/range_based_api.rst Outdated Show resolved Hide resolved
documentation/library_guide/parallel_api/range_based_api.rst Outdated Show resolved Hide resolved
documentation/library_guide/parallel_api/range_based_api.rst Outdated Show resolved Hide resolved
documentation/library_guide/parallel_api/range_based_api.rst Outdated Show resolved Hide resolved
@akukanov akukanov added this to the 2022.7.0 milestone Aug 19, 2024
dmitriy-sobolev
dmitriy-sobolev previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am ready to reapprove if #1596 (comment) is addressed.

@akukanov akukanov requested review from danhoeflinger, dmitriy-sobolev and timmiesmith and removed request for akukanov and ValentinaKats September 17, 2024 11:01
@akukanov @danhoeflinger
Fix a typo
6d00f35 
Co-authored-by: Dan Hoeflinger <[email protected]>
danhoeflinger
danhoeflinger previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this has some nice improvements to the documentation, in addition to adding the range based API

dmitriy-sobolev
dmitriy-sobolev previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danhoeflinger
danhoeflinger previously approved these changes Sep 17, 2024
View reviewed changes
dcbenito
dcbenito reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@dcbenito dcbenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes requested, otherwise LGTM.

documentation/library_guide/parallel_api/parallel_range_algorithms.rst Outdated Show resolved Hide resolved
documentation/library_guide/parallel_api/parallel_range_algorithms.rst Outdated Show resolved Hide resolved
@akukanov akukanov merged commit e064993 into main Sep 17, 2024
22 checks passed
@akukanov akukanov deleted the std_ranges_support_as_ext branch September 17, 2024 18:08
@dmitriy-sobolev dmitriy-sobolev mentioned this pull request Sep 20, 2024
Merged
mmichel11 pushed a commit that referenced this pull request Sep 25, 2024
@MikeDvorskiy @akukanov
@dmitriy-sobolev @danhoeflinger @mmichel11
Add documentation for parallel range algorithms (#1596)
c27700a 
Co-authored-by: Alexey Kukanov <[email protected]>
Co-authored-by: Dmitriy Sobolev <[email protected]>
Co-authored-by: Dan Hoeflinger <[email protected]>
timmiesmith pushed a commit that referenced this pull request Nov 15, 2024
@MikeDvorskiy @akukanov
@dmitriy-sobolev @danhoeflinger @timmiesmith
Add documentation for parallel range algorithms (#1596)
22db30f 
Co-authored-by: Alexey Kukanov <[email protected]>
Co-authored-by: Dmitriy Sobolev <[email protected]>
Co-authored-by: Dan Hoeflinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akukanov akukanov akukanov left review comments

@dcbenito dcbenito dcbenito approved these changes

@danhoeflinger danhoeflinger danhoeflinger left review comments

@dmitriy-sobolev dmitriy-sobolev dmitriy-sobolev left review comments

@rarutyun rarutyun Awaiting requested review from rarutyun

@mmichel11 mmichel11 Awaiting requested review from mmichel11

@timmiesmith timmiesmith Awaiting requested review from timmiesmith

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2022.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@MikeDvorskiy @akukanov @dmitriy-sobolev @dcbenito @mmichel11 @danhoeflinger