Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog validation: ensure changelog filename matches the package name #9633

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cbbayburt
Copy link
Contributor

GUI Diff

Before:

> changelogs.py java/spacewalk-NOT-JAVA.changes.cbbayburt.test ...

INFO: Changelog test passed

After:

> changelogs.py java/spacewalk-NOT-JAVA.changes.cbbayburt.test ...

INFO: Changelog test failed with 1 issue(s):
------------------------------------------------------------
ERROR: Changelog filename must be in format: 'spacewalk-java.changes.<author>.<feature>' for package spacewalk-java

Test coverage

  • Unit tests were added

Links

Fixes #9480

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@cbbayburt cbbayburt requested a review from a team as a code owner January 15, 2025 15:04
@cbbayburt cbbayburt requested review from vzhestkov and removed request for a team January 15, 2025 15:04
@cbbayburt cbbayburt force-pushed the changelog-action branch 3 times, most recently from 395bf15 to 54aaac3 Compare January 16, 2025 14:21
@cbbayburt cbbayburt requested a review from cbosdo January 22, 2025 14:20
Copy link
Contributor

@cbosdo cbosdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changelog test: Check if the changelog file name matches the package name
2 participants