Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
jouni authored Nov 28, 2023
1 parent 73f34b2 commit 3bddaa3
Show file tree
Hide file tree
Showing 16 changed files with 19 additions and 16 deletions.
2 changes: 1 addition & 1 deletion articles/styling/advanced/loading-styles-dynamically.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Loading Stylesheets Dynamically
description: Explains how dynamically to load style sheets.
description: Explains how dynamically to load stylesheets.
order: 70
---

Expand Down
2 changes: 1 addition & 1 deletion articles/styling/advanced/themes-for-embedded.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Application Themes for Embedded Components
description: Straightforward explanation on embedding themes in an application's components.
description: Things to consider when using a custom theme for embedded applications.
order: 90
---

Expand Down
2 changes: 1 addition & 1 deletion articles/styling/legacy/css-import.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: CssImport Annotation
description: Information on the an earlier annotation for importing style sheets.
description: Information on the legacy CssImport annotation for importing stylesheets.
---


Expand Down
3 changes: 2 additions & 1 deletion articles/styling/legacy/material-theme/index.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
title: Material Theme
description: Information on the Material Theme, which is not being developed further.
description: Information on the Material theme, which is not being developed further.

order: 10
---

Expand Down
3 changes: 2 additions & 1 deletion articles/styling/legacy/material-theme/typography.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
title: Typography
description: Description and table of Material style settings related to displaying and formatting text.
description: Material theme style properties related to displaying and formatting text.

order: 10
---

Expand Down
2 changes: 1 addition & 1 deletion articles/styling/lumo/lumo-style-properties/color.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Color
description: Tables of colors used in the Lumo theme.
description: Colors and their corresponding style properties defined in the Lumo theme.
order: 10
page-links:
- https://github.com/vaadin/web-components/blob/v{moduleNpmVersion:vaadin-lumo-styles}/packages/vaadin-lumo-styles/color.js[Source]
Expand Down
2 changes: 1 addition & 1 deletion articles/styling/lumo/lumo-style-properties/elevation.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Elevation
description: Table of Lumo elevation style properties, the visual stacking of elements in a UI.
description: Listing of Lumo elevation style properties, the visual stacking of elements in a UI.
order: 50
page-links:
- https://github.com/vaadin/web-components/blob/v{moduleNpmVersion:vaadin-lumo-styles}/packages/vaadin-lumo-styles/style.js[Source]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Interaction
description: Setting the pointer icon for an application with Lumo.
description: Lumo style properties related to how interactions are indicated in an application, mainly by different mouse cursors.
order: 60
page-links:
- https://github.com/vaadin/web-components/blob/v{moduleNpmVersion:vaadin-lumo-styles}/packages/vaadin-lumo-styles/style.js[Source]
Expand Down
2 changes: 1 addition & 1 deletion articles/styling/lumo/lumo-style-properties/shape.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Shape
description: Description and table of Lumo style settings related to component shapes.
description: Describing the Lumo style properties related to component shapes.
order: 40
page-links:
- https://github.com/vaadin/web-components/blob/v{moduleNpmVersion:vaadin-lumo-styles}/packages/vaadin-lumo-styles/style.js[Source]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Size pass:[&] Space
description: Tables of Lumo style properties related to setting the size and spacing of text and components.
description: Listing of Lumo style properties related to setting the size and spacing of text and components.
order: 30
page-links:
- https://github.com/vaadin/web-components/blob/v{moduleNpmVersion:vaadin-lumo-styles}/packages/vaadin-lumo-styles/sizing.js[Source (size)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ page-links:

= Lumo Typography

Lumo defines a set of style properties, CSS custom properties for font family, font size, and line height. You can use these CSS custom properties to apply consistent typographic styles across your application.
Lumo defines a set of style properties for font family, font size, and line height. You can use these CSS custom properties to apply consistent typographic styles across your application.

You can enable the built-in <<{articles}/styling/lumo/lumo-variants#, Lumo compact mode variant>> to reduce the font size and the sizing and spacing of all components, allowing you to place more components on the screen.

Expand Down
3 changes: 2 additions & 1 deletion articles/styling/lumo/lumo-variants.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
title: Lumo Variants
description: Understanding and utilizing color and compact variants in Lumo.
description: Understanding and utilizing the built-in light, dark, and compact variants in Lumo.

order: 20
---

Expand Down
2 changes: 1 addition & 1 deletion articles/styling/lumo/utility-classes.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Utility Classes
description: List of Lumo Utility classes and descriptions of them.
description: List of Lumo utility classes and descriptions of them.
order: 30
---

Expand Down
2 changes: 1 addition & 1 deletion articles/styling/styling-components/index.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Styling Vaadin Components
description: Explanation and examples on how to make use of built-in Lumo styles and add your own.
description: Explanation and examples on how to customize the styling of Vaadin components.
order: 30
---

Expand Down
2 changes: 1 addition & 1 deletion articles/styling/styling-components/parts-and-states.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Stylable Parts pass:[&] States
description: Details on the various stylable component parts and their states.
description: Learn what stylable component parts and states are and how to use them when customizing the styles of Vaadin components.
order: 10
---

Expand Down
2 changes: 1 addition & 1 deletion articles/styling/styling-other-elements.adoc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
title: Styling Other UI Elements
description: Describes how to apply styles to common and uncommon CSS elements.
description: Describes how to apply styles to common and uncommon HTML elements.
order: 40
---

Expand Down

0 comments on commit 3bddaa3

Please sign in to comment.