Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add accessor keywords to decorated fields #2931

Merged
merged 9 commits into from
Nov 3, 2023

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Oct 31, 2023

This PR includes the following changes and fixes the development mode on latest branch:

  • Bump DSP version to 2.2.0-rc.2 with support for useStandardDecorators config option
    • Add "useStandardDecorators": true to config files
    • Add accessor keywords to decorated fields as advised here
  • bump Hilla version
  • bump @hilla/react-components version

@tomivirkki tomivirkki marked this pull request as draft October 31, 2023 10:58
@tomivirkki tomivirkki marked this pull request as ready for review November 3, 2023 08:19
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM. Tried to run the branch locally and got the following error:

Screenshot 2023-11-03 at 10 55 34

@tomivirkki
Copy link
Member Author

The change LGTM. Tried to run the branch locally and got the following error

Declared the module to avoid the error

@tomivirkki tomivirkki merged commit f8cec58 into latest Nov 3, 2023
@tomivirkki tomivirkki deleted the use-accessor-for-decorated-fields branch November 3, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants