docs: address DX test feedback for Hilla 2.4 #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language unchecked
sissbruecker
commented
Nov 15, 2023
| @@ -40,7 +40,12 @@ include::{root}/src/main/java/com/vaadin/demo/fusion/crud/EmployeeRepository.jav | |||
|
|
|||
| Hilla generates TypeScript objects for each `@BrowserCallable` service implementing the `CrudService<T, ID>` interface. These TypeScript objects have callable methods that execute the corresponding Java service methods, enabling the Add, Update, and Delete operations as well as lazy data loading with sorting and filtering. | |||
|
|
|||
| For the `EmployeeService` example, you can import the generated TypeScript object in your React view, and use it as a value for the `<AutoForm service={EmployeeService} />` property to render the form. | |||
There was a problem hiding this comment.
Some testers referred to the example code in this paragraph when creating the initial component, and also missed to expand the code snippet in the example below. They were then confused why they ended up with a partially configured component and had compiler errors. Changed this in both articles to show a proper code snippet with a fully configured component.
| @@ -115,7 +115,7 @@ export default function ProductDetailView() { | |||
| const { productId } = useParams(); | |||
|
|
|||
| // Fetch product details for the given ID | |||
| const { product, setProduct } = useState<Product>(); | |||
| const [ product, setProduct ] = useState<Product>(); | |||
There was a problem hiding this comment.
Only semi-related, but discovered this syntax issue as part of the tests.
sissbruecker
removed
the
Language unchecked
taefi
reviewed
Nov 15, 2023
taefi
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some smaller issues that came up in DX tests.