docs: update MenuBar docs to use CSS class #3048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Language unchecked
rolfsmeds
requested changes
Dec 13, 2023
| vaadin-menu-bar-button[theme~="custom-theme"], | ||
| vaadin-menu-bar-item[theme~="custom-theme"] { | ||
| vaadin-menu-bar-button.custom-classname, | ||
| vaadin-menu-bar-item.custom-classname { | ||
| text-transform: uppercase; |
There was a problem hiding this comment.
We could change the styling to something people actually might notice, like background color?
There was a problem hiding this comment.
Changed to use Lumo utility classes and removed this file.
| An individual menu item can be styled using custom theme variants. A custom variant can be created by adding a custom theme name (e.g., `custom-theme`) to an item, and then adding CSS for styling all items using that theme name. | ||
|
|
||
| The following example shows how to add a custom theme variant named `custom-theme` to individual menu bar buttons and items, and how to style that variant with CSS: | ||
| Individual menu items can be styled by [since:com.vaadin:[email protected]]##applying custom classnames to them##, and writing CSS style blocks targeting those classnames. Note that root-level menu items in the Menu Bar are wrapped inside `vaadin-menu-bar-button` elements which inherit the classnames from the items inside them. |
There was a problem hiding this comment.
Apparently we've decided to go with "class names" instead of "classnames" in docs, so let's change all occurrences to that.
russelljtdyer
added
Language checking
rolfsmeds
approved these changes
Dec 14, 2023
russelljtdyer
added
Language checked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update MenuBar documentation to use CSS classes instead of the theme API
Fixes #3030