Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update hilla version to 2.5.0.rc1 #3049

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

tomivirkki
Copy link
Member

Commit automatic dependency bumps applied by Vaadin upon server startup.

IMO the dependency updates should be part of the automatic Vaadin version bump PR

@tomivirkki tomivirkki requested a review from ZheSun88 December 13, 2023 07:33
@ZheSun88
Copy link
Contributor

I wonder why this change was not in commit (https://github.com/vaadin/docs/pull/3044/files)

does it need some extra way to generate those changes?

@tomivirkki
Copy link
Member Author

does it need some extra way to generate those changes?

Just running mvn (to start up in dev)

@ZheSun88
Copy link
Contributor

this is what we do to generate the version update PR
need to change something?

mvn -B -q versions:set-property -Dproperty=vaadin.version -DnewVersion=%version% -DgenerateBackupPoms=false && \
mvn -U -ntp install -Pproduction

@tomivirkki
Copy link
Member Author

That's only running the production build. Maybe starting up in dev mode updates additional dependencies. Try running mvn.

@ZheSun88
Copy link
Contributor

running mvn seems calling spring-boot:run which starts the server but it will not stop automatically. so the build will just hang there.

seems the difference between profile production and default run is the prepare-frontend goal.
maybe we should add it here.

@ZheSun88
Copy link
Contributor

ZheSun88 commented Dec 13, 2023

seems the thing we need to do here is update the hilla.version to its latest 2.5.0.rc1

currently, hilla release is missing the version update here. when calling hilla-maven-plugin with an outdated version lead the dependency un-updated.

@ZheSun88 ZheSun88 changed the title chore: automatically updated dependencies chore: update hilla version to 2.5.0.rc1 Dec 13, 2023
@ZheSun88 ZheSun88 merged commit bc5f086 into latest Dec 13, 2023
3 of 4 checks passed
@ZheSun88 ZheSun88 deleted the chore/bump-versions branch December 13, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants