Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade to 24.4.0.beta1 #3391

Merged
merged 8 commits into from
Apr 30, 2024
Merged

chore: Upgrade to 24.4.0.beta1 #3391

merged 8 commits into from
Apr 30, 2024

Conversation

mshabarov
Copy link
Contributor

@mshabarov mshabarov commented Apr 25, 2024 •
edited
Loading

Upgrades docs to 24.4.0.alpha24.
Refactors menu bar icons codes, so that it doesn't give the following TS errors (see this build):

[ERROR] frontend/demo/component/menubar/react/menu-bar-icons.tsx(10,15): error TS2339: Property 'width' does not exist on type 'CSSProperties'.
[ERROR] frontend/demo/component/menubar/react/menu-bar-icons.tsx(11,15): error TS2339: Property 'height' does not exist on type 'CSSProperties'.
[ERROR] frontend/demo/component/menubar/react/menu-bar-icons.tsx(12,15): error TS2339: Property 'marginRight' does not exist on type 'CSSProperties'.

@github-actions github-actions bot added the Language unchecked English language and AsciiDoc formatting checks haven't been done label Apr 25, 2024
@mshabarov mshabarov requested a review from tomivirkki April 25, 2024 13:23
@ZheSun88 ZheSun88 removed the Language unchecked English language and AsciiDoc formatting checks haven't been done label Apr 26, 2024
@ZheSun88 ZheSun88 changed the title chore: Upgrade to 24.4.0.alpha24 chore: Upgrade to 24.4.0.beta1 Apr 30, 2024
@ZheSun88 ZheSun88 marked this pull request as ready for review April 30, 2024 16:15
@ZheSun88 ZheSun88 merged commit 9eca8d8 into next Apr 30, 2024
3 checks passed
@ZheSun88 ZheSun88 deleted the upgrade-to-alpha24 branch April 30, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki left review comments

@ZheSun88 ZheSun88 ZheSun88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshabarov @tomivirkki @ZheSun88 @platosha