Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to wrap a field React component into Flow component #3600

Merged
merged 17 commits into from
Aug 22, 2024

Conversation

AlainaFaisal
Copy link
Contributor

@AlainaFaisal AlainaFaisal commented Aug 14, 2024

Document of an example in React integration docs how to wrap a React component as a Field Flow component with AbstractSinglePropertyField

Fixes #3421

@AlainaFaisal AlainaFaisal requested a review from caalador August 14, 2024 09:35
@github-actions github-actions bot added the Language unchecked English language and AsciiDoc formatting checks haven't been done label Aug 14, 2024
@AlainaFaisal AlainaFaisal requested a review from vursen August 15, 2024 08:07
.github/workflows/alex.yml Outdated Show resolved Hide resolved
articles/flow/integrations/react.adoc Outdated Show resolved Hide resolved
articles/flow/integrations/react.adoc Outdated Show resolved Hide resolved
articles/flow/integrations/react.adoc Outdated Show resolved Hide resolved
articles/flow/integrations/react.adoc Outdated Show resolved Hide resolved
articles/flow/integrations/react.adoc Outdated Show resolved Hide resolved
articles/flow/integrations/react.adoc Outdated Show resolved Hide resolved
articles/flow/integrations/react.adoc Show resolved Hide resolved
articles/flow/integrations/react.adoc Outdated Show resolved Hide resolved
articles/flow/integrations/react.adoc Outdated Show resolved Hide resolved
articles/flow/integrations/react.adoc Outdated Show resolved Hide resolved
@AlainaFaisal AlainaFaisal merged commit a9454fe into latest Aug 22, 2024
3 checks passed
@AlainaFaisal AlainaFaisal deleted the react-integration branch August 22, 2024 07:22
@@ -208,3 +208,84 @@ class ReactRouterLayoutElement extends ReactAdapterElement {

customElements.define('react-router-layout', ReactRouterLayoutElement);
----

[[wrap-react-component]]
== Wrapping a React Component Into a Flow Component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be like "Wrapping a React Input Component Into a Flow Field Component".

Sorry for commenting on a closed PR, but just noticed one small remark. Could you change it in another PR ?

@AlainaFaisal

mshabarov pushed a commit that referenced this pull request Aug 22, 2024
…low component #3600 (#3609)

* Update PR check configs from master

* changing title

* Delete .github/workflows/alex.yml

---------

Co-authored-by: Jouni Koivuviita <[email protected]>
@russelljtdyer
Copy link
Collaborator

Language was checked in #3631 .

@russelljtdyer russelljtdyer added Language checked English language and AsciiDoc formatting checks done and removed Language unchecked English language and AsciiDoc formatting checks haven't been done labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language checked English language and AsciiDoc formatting checks done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to wrap a field React component into Flow component
6 participants