Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add banner at the end of the toc section #3947

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Add banner at the end of the toc section #3947

merged 3 commits into from
Dec 12, 2024

Conversation

marcushellberg
Copy link
Member

@marcushellberg marcushellberg commented Nov 25, 2024 •
edited
Loading

TODO:

  • Update image
  • Fix how the banner is displayed on a narrow viewport

@marcushellberg marcushellberg requested a review from jouni November 25, 2024 23:02
@marcushellberg marcushellberg marked this pull request as ready for review December 12, 2024 17:33
jouni
jouni approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@jouni jouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would’ve expected that you’d want the banner to be visible even if the TOC is collapsed on small viewport sizes. But if this is the behavior you want, I don't have any issue with it.

@jouni jouni merged commit bee00d8 into latest Dec 12, 2024
3 of 4 checks passed
@jouni jouni deleted the toc-training-banner branch December 12, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jouni jouni jouni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcushellberg @jouni