Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin Way docs: Designing for responsiveness #3978

Merged
merged 14 commits into from
Dec 11, 2024

Conversation

juuso-vaadin
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Language unchecked English language and AsciiDoc formatting checks haven't been done label Dec 4, 2024
Copy link
Member

@jouni jouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some drive-by commenting.

Copy link
Member

@peholmst peholmst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now edited the article according to my vision of The Vaadin Way. @russelljtdyer will likely do some more editing during the language check. I've also added some comments on places that I think are unclear still.

@juuso-vaadin Please read through the edited article to make sure I have not messed anything up.

Fixes CSS code samples
@peholmst peholmst merged commit 926f2d0 into latest Dec 11, 2024
3 of 4 checks passed
@peholmst peholmst deleted the designing-apps-responsiveness branch December 11, 2024 07:19
@jouni jouni removed the Language unchecked English language and AsciiDoc formatting checks haven't been done label Jan 10, 2025
@jouni
Copy link
Member

jouni commented Jan 10, 2025

I removed the Language unchecked label since these updates are included in a later PR (content moved to a new section): #3993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants