Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old hilla.dev links from v23 #4005

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Conversation

veerapaananen
Copy link
Collaborator

Old hilla.dev links redirect to vaadin.com now. This fix replaces those links in the docs for version 23 with the final addresses they currently redirect to, removing the old links pointing to hilla.dev and removing redirections.

Example:

Old link: https://hilla.dev/
New link: https://vaadin.com/hilla

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ peholmst
❌ Veera Paananen


Veera Paananen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@peholmst
Copy link
Member

V23 Hilla links should not point to the latest version of Hilla, but the to the version that works with Vaadin 23. Unfortunately that documentation is currently not available anywhere.

@veerapaananen
Copy link
Collaborator Author

Those links redirect now to the latest documentation anyway. Should the links be removed instead? @peholmst

@peholmst
Copy link
Member

Given the situation right now, they should be removed. But if we end up publishing the documentation for the old Hilla versions somewhere, they would have to be added back.

@veerapaananen
Copy link
Collaborator Author

I'll do some changes and update this PR. Let's add the links back if/when the old Hilla docs are published.

@peholmst peholmst merged commit c5e80a2 into v23 Dec 19, 2024
2 of 3 checks passed
@peholmst peholmst deleted the fix/remove-hilla-redirections-v23 branch December 19, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants