fix: build service worker without writing it to FS #20909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
commented
Jan 24, 2025
| }, | ||
| async load(id) { | ||
| if (id.endsWith('sw.js')) { | ||
| return buildOutput.output[0].code; |
There was a problem hiding this comment.
note: The output code already includes a sourcemap link, so there is no need to return sourcemaps separately in transform(code, id) as it was done previously.
1 task
|
mcollovati
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#20894 reintroduced #13123 where the service worker build would cause a server restart in dev mode. This PR fixes this issue again.
Type of change