fix: remove the undefined return type for Flux endpoint methods (#510)

vaadin · Aug 17, 2022 · e2f4dc3 · e2f4dc3
1 parent 6fd93b7
commit e2f4dc3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/java/endpoint/src/main/java/dev/hilla/generator/typescript/CodeGenerator.java b/packages/java/endpoint/src/main/java/dev/hilla/generator/typescript/CodeGenerator.java
@@ -318,8 +318,8 @@ public String getTypeDeclaration(Schema schema) {
             Schema inner = arraySchema.getItems();
             if (schema.getExtensions() != null
                     && schema.getExtensions().containsKey("x-flux")) {
-                return String.format("Subscription<%s>%s",
-                        this.getTypeDeclaration(inner), optionalSuffix);
+                return String.format("Subscription<%s>",
+                        this.getTypeDeclaration(inner));
             } else {
                 return String.format("Array<%s>%s",
                         this.getTypeDeclaration(inner), optionalSuffix);

diff --git a/...dpoint/src/test/resources/dev/hilla/generator/endpoints/flux/expected-FluxTestEndpoint.ts b/...dpoint/src/test/resources/dev/hilla/generator/endpoints/flux/expected-FluxTestEndpoint.ts
@@ -23,7 +23,7 @@ Subscription<User> {
 * Return a list of users
 */
 function _getAllUsers():
-Subscription<User | undefined> | undefined {
+Subscription<User | undefined> {
   return client.subscribe (
     'FluxTestEndpoint', 'getAllUsers',{}
   );