fix: restore autofocus manually for now

vaadin · Dec 8, 2023 · dac6a40 · dac6a40
1 parent 4d4979c
commit dac6a40
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/utils/createComponent.ts b/src/utils/createComponent.ts
@@ -64,7 +64,8 @@ type AllWebComponentProps<I extends HTMLElement, E extends EventNames = {}> = I
   ? ThemedWebComponentProps<I, E>
   : _WebComponentProps<I, E>;
 
-type OmittedWebComponentProps = Omit<HTMLElement, keyof React.HTMLAttributes<any>> & ControllerMixinClass;
+// TODO: LoginOverlay has "autofocus" property so we can't omit it
+type OmittedWebComponentProps = Omit<HTMLElement, keyof React.HTMLAttributes<any> | 'autofocus'> & ControllerMixinClass;
 
 export type WebComponentProps<I extends HTMLElement, E extends EventNames = {}> = Omit<
   AllWebComponentProps<I, E>,

diff --git a/test/typings/api.ts b/test/typings/api.ts
@@ -4,6 +4,7 @@ import type { LitElement } from 'lit';
 import { GridColumn, GridColumnElement } from '../../GridColumn.js';
 import { Dialog, DialogElement } from '../../Dialog.js';
 import { DatePicker, DatePickerElement } from '../../DatePicker.js';
+import { LoginOverlay, LoginOverlayElement } from '../../LoginOverlay.js';
 import { TimePicker, type TimePickerChangeEvent } from '../../TimePicker.js';
 import { TextArea, TextAreaElement, type TextAreaChangeEvent } from '../../TextArea.js';
 import { MessageInput, MessageInputElement, type MessageInputSubmitEvent } from '../../MessageInput.js';
@@ -93,3 +94,7 @@ const textAreaOnChange: typeof textAreaProps.onChange = (event) => {
 const timePickerProps = React.createElement(TimePicker, {}).props;
 
 assertType<typeof timePickerProps.onChange>((_event: TimePickerChangeEvent) => {});
+
+const loginOverlayProps = React.createElement(LoginOverlay, {}).props;
+
+assertType<LoginOverlayElement['autofocus'] | undefined>(loginOverlayProps.autofocus);