fix: make useRenderer hook synchronous #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 25 25
Lines 175 175
Branches 20 20
=======================================
Hits 173 173
Misses 1 1
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Lodin
previously approved these changes
Dec 15, 2023
web-padawan
previously approved these changes
Dec 15, 2023
web-padawan
reviewed
Dec 15, 2023
web-padawan
approved these changes
Dec 15, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
web-padawan
pushed a commit
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Tomi Virkki <[email protected]>
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the
useRendererhook updates synchronous to fix timing issues.Fixes #129
Mostly covers also #75
Type of change
Bugfix