Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix grid-pro tests #260

Merged
merged 1 commit into from
Oct 8, 2024
Merged

test: fix grid-pro tests #260

merged 1 commit into from
Oct 8, 2024

Conversation

tomivirkki
Copy link
Member

Description

Fix GridPro test cases to make them pass with this web component change.

This change should be cherry-picked to 24.5 and 24.4

Type of change

Tests

@tomivirkki tomivirkki requested a review from web-padawan October 8, 2024 10:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (b944930) to head (c1ede7b).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   95.89%   94.98%   -0.91%     
==========================================
  Files          30       31       +1     
  Lines         292      299       +7     
  Branches       35       35              
==========================================
+ Hits          280      284       +4     
  Misses          3        3              
- Partials        9       12       +3     
Flag Coverage Δ
unittests 94.98% <ø> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@web-padawan web-padawan merged commit 98e5551 into main Oct 8, 2024
2 checks passed
@web-padawan web-padawan deleted the test/fix-grid-pro-test branch October 8, 2024 11:12
vaadin-bot pushed a commit that referenced this pull request Oct 8, 2024
vaadin-bot pushed a commit that referenced this pull request Oct 8, 2024
web-padawan pushed a commit that referenced this pull request Oct 8, 2024
web-padawan pushed a commit that referenced this pull request Oct 8, 2024
web-padawan pushed a commit that referenced this pull request Oct 8, 2024
web-padawan pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants