Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add holidays from Prophet #538

Closed
ourownstory opened this issue Oct 7, 2021 · 5 comments
Closed

Please add holidays from Prophet #538

ourownstory opened this issue Oct 7, 2021 · 5 comments
Labels
enhancement help wanted

Comments

@ourownstory
Copy link

ourownstory commented Oct 7, 2021 •
edited
Loading

Thank you for this great library. We at NeuralProphet would like to be able to rely 100% on your great package.
However, you are lacking a few important countries, which we have to manually sync from Prophet.
If you could add those, it would make NeuralProphet's and Prophet's codebase simpler to maintain.

Prophet supports the following countries missing in your library:

  • Indonesia
  • Thailand
  • Philippines
  • Pakistan
  • Belarus
  • India (currently defined: 8 holidays, while Prophet has 22)

You can find the relevant code here:
https://github.com/facebook/prophet/blob/master/python/prophet/hdays.py

"All that is needed" is to write tests for these countries, the holidays are all already defined.

If someone would be down to take on this task, we would be very thankful!
This was referenced Oct 7, 2021
Closed
Merged
canute24 added a commit to canute24/python-holidays that referenced this issue Nov 9, 2021
@canute24
Added missing states and two major holidays
35a996a 
- Updated borked calendarlab link and added new references for changes done
- Missing states and union territories added to list
- Sorted state list by status first and then alphabetically (UT's at the bottom)
- Full state names in comments along side state codes
- State code for Odisha changed to "OR" as used in govt websites
- Added Diwali and Holi from FBProphet as requested in vacanza#538 (only for India)
- Added warnings regarding year range for Diwali and Holi as in FBProphet
@canute24 canute24 mentioned this issue Nov 9, 2021
Merged
@dr-prodigy
Copy link
Collaborator

Hi @ourownstory thank you for your interest in python_holidays.

It would be great if you could contribute to it, if you can, thx!

In the meanwhile, I mark this as "help wanted".

Cheers!

@ourownstory
Copy link
Author

Hi @dr-prodigy I am happy to contribute everything but the tests...

@tserekh
Copy link
Contributor

tserekh commented Nov 17, 2021

I can work on it

@tserekh tserekh mentioned this issue Nov 20, 2021
Closed
dr-prodigy added a commit that referenced this issue Jan 4, 2022
@dr-prodigy @dependabot
@canute24 @cturra @khawley @chiuczek @eldar-mustafayev @tserekh @ihebski @ifurther @mborsetti @mmontel-wgs @dongho-jung @tedtad @antusystem @javicalle @aa-netnovation @amelkiy
v.0.12 release (#585)
57dd2ed 
* Bump pre-commit/action from 2.0.0 to 2.0.3

Bumps [pre-commit/action](https://github.com/pre-commit/action) from 2.0.0 to 2.0.3.
- [Release notes](https://github.com/pre-commit/action/releases)
- [Commits](pre-commit/action@v2.0.0...v2.0.3)

---
updated-dependencies:
- dependency-name: pre-commit/action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Added missing states and two major holidays

- Updated borked calendarlab link and added new references for changes done
- Missing states and union territories added to list
- Sorted state list by status first and then alphabetically (UT's at the bottom)
- Full state names in comments along side state codes
- State code for Odisha changed to "OR" as used in govt websites
- Added Diwali and Holi from FBProphet as requested in #538 (only for India)
- Added warnings regarding year range for Diwali and Holi as in FBProphet

* Update corresponding tests

- Removed duplicate test for Gujarat
- Added new tests for Diwali and Holi

* v.0.11.4 beta

* Canada :: National Day for Truth and Reconciliation (#533)

earlier this year the government of Canada announced a new federal
holiday, National Day for Truth and Reconciliation. for 2021, two
provinces have adopted this day as an official holiday: Manitoba
and Nova Scotia. i'd expect by next year more to follow and will
update accordingly at that time.

* get full test coverage for canadian holidays (#536)

* add Juneteenth Observed holiday support (#537)

* Grammatical changes in docs (#549)

Spelling and grammar update. Excuse my OCD.

* CHANGES sync

* Add holidays for Kazakhstan (#534)

* Initial rough set of holidays for Kazakhstan
* Add tests for Kazakhstan holidays in 2020
* Adjust Kaz holidays to master and update tests
Co-authored-by: Hugh McNamara <[email protected]>

* README+CHANGES sync

* flake8 compliance

* Add public holidays of Azerebaijan (#540)

Co-authored-by: Eldar Mustafayev <[email protected]>

* CHANGES sync

* Warning review, CHANGES sync

* Spain fixes on PV (#555)

* CHANGES sync

* Add public holidays of Tunisia (#543)

* Add public holidays of Taiwan (#547)

* CHANGES + README.rst sync

* Fix India (Dussehra) #539

* Travis integration removal (#557)

* Italy fixes #546, CHANGES sync

* Italy fixes #546 - tests

* Patch/kor alt holidays (#535)

* remove unused statements
* add a comment for alternative holdays in Korea
* remove alternative holiday for New Year's Day, because it doesn't have it
* revise the comment for alternative holidays in Korea
* Korea alt holiday of Lunar New Year's Day should be next first non holiday after the holiday, not just +2
* remove first_lower util as its sole usage was gone
* edit Independence Movement Day because it also has alt holiday since 2021
* handle the case when two holidays are overlap (e.g. 2025/05/05)
* refactor Liberation Day
* fix Chuseok misnomer, refactor logic
* fix alt holiday for Hangul Day and add its testcase
* fix alt holiday for National Foundation Day and add its testcase
* quality assurance

* CHANGES sync

* Test coverage improvement

* Create Ethiopia.py

Adding Ethiopian holiday

* Update Ethiopia.py

* Update __init__.py

* Create test_ethiopia.py

* Update README.rst

* Update test_ethiopia.py

* More useful __repr__ and __str__ (#360)

* README change: more added test coverage requirements

* Date slices support fix #529, #530

* US Virginia Lee Jackson Day Removed After 2020 #559

* Update Ethiopia.py

Defining is_leap_year function

* test_coverage

Adding aditional test coverage

* Rename Ethiopia.py to ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Configs

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update test_egypt.py

* Update ci-cd.yml

* Update test_malaysia.py

* config

* Update test_ethiopia.py

* Update test_ethiopia.py

* Update ethiopia.py

* Update ethiopia.py

* Update ethiopia.py

* Update test_ethiopia.py

* Create codeql-analysis.yml

* Delete codeql-analysis.yml

* Sphinx support - doc stub (#526)

* README.rst sync

* Add all test submodules automatically

* .gitattributes fix (#522)

* Update __init__.py

* Conflict resolution

* Update __init__.py

* Update colombia.py (#564) - redo

* Removed tests.py (obsolete)

* Czech (ie: misspelled Czechia) deprecated support removed

* UK standalone states deprecation #566

* UK standalone states deprecation #566

* Venezuela ISO code fix (#567)

* README.rst, CHANGES sync

* Support for North Macedonia (#570)

* README.rst, CHANGES sync

* UK standalone states deprecation #566 - better compatibility

* Update ethiopia.py

* Update ethiopia.py

* Support for Ethiopia (#558)

* CI/CD +python 3.10

* Update ethiopia.py

* Update test_ethiopia.py

More test coverages

* Revert "CI/CD +python 3.10"

This reverts commit c38dbaa.

* Updated venezuela.py

I added "Muerte del Libertador Simón Bolívar", which was missing, though, some people say its not a true holiday, but it is in my experience

* Updated venezuela.py

I added "Muerte del Libertador Simón Bolívar" test, which was missing, though, some people say its not a true holiday, but it is in my experience

* Update test_venezuela.py

Added a correction to pass the pull request test

* Update test_venezuela.py

Added a correction to pass the pull request test

* Add `NorthMacedonia` import to __init__ (#574)

Fix missing import for `NorthMacedonia` class/country.

* 'Polish' support drop

* 'Slovak' support drop

* UK states README fix

* Modified venezuela.py with pre-commit

* Defining ethiopian_isleap function

To properly calculate holidays between Sep 11 and Jan 1. Ethiopian isleap function should add 1 to current year.

* Venezuela fixes #576

* CHANGES sync

* UK fixes

* Moved country to class attribute (#573)

* CHANGES sync

* added observed support for Juneteenth Day

* Tests for observed Juneteenth Day

* copyright 2022, new version 0.12

* CD/CI tests - Pypi versions review

* removed pypy-3.6 tests for macOS compatibility

* even safer pypy tests for macOS compatibility

* Add Observed support for Juneteenth Day (#578)

* v.0.12

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Canute <[email protected]>
Co-authored-by: Chris Turra <[email protected]>
Co-authored-by: Kelsey Karin Hawley <[email protected]>
Co-authored-by: Hugh McNamara <[email protected]>
Co-authored-by: Eldar Mustafayev <[email protected]>
Co-authored-by: Eldar Mustafayev <[email protected]>
Co-authored-by: Artem Tserekh <[email protected]>
Co-authored-by: Ihebski <[email protected]>
Co-authored-by: Further <[email protected]>
Co-authored-by: Mike Borsetti <[email protected]>
Co-authored-by: mmontel-wgs <[email protected]>
Co-authored-by: jdh <[email protected]>
Co-authored-by: Tewodros Meshesha <[email protected]>
Co-authored-by: antusystem <[email protected]>
Co-authored-by: javicalle <[email protected]>
Co-authored-by: Alejandro Antunes <[email protected]>
Co-authored-by: amelkiy <[email protected]>
@ourownstory
Copy link
Author

Thank you @tserekh ! Please let me know when your work is merged!

@arkid15r
Copy link
Collaborator

The requested countries have been added in v0.20.
Please review ourownstory/neural_prophet#1176

Thank you for using python-holidays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arkid15r @ourownstory @tserekh @dr-prodigy