Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETH-SECPM-DEC #28

Merged
merged 57 commits into from
May 27, 2024
Merged

ETH-SECPM-DEC #28

merged 57 commits into from
May 27, 2024

Conversation

ramsesfv
Copy link
Contributor

No description provided.

@kaiserd kaiserd requested a review from rymnc April 29, 2024 09:18
@rymnc rymnc requested review from kaiserd, seemenkina and seugu April 29, 2024 09:18
Copy link
Contributor

@seemenkina seemenkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, just want to say that the rfc is very detailed and easy to read, thanks for doing such a great job

I have left some corrections regarding the labelling (mainly removed the artefact from the latex)

I would really like to see the code labelled (add tabs) because sometimes I have to go into the text to understand what belongs to which block.

I still have questions about the member-view function - it's not very clear what kind of data it will work with - only IDs or something else?

And similarly about gamma.history - I understand that this is a set of actions that the user has performed in the form of an array of sequences like op = ("action", sender, seq, <additional data> ). And <additional data> is not specified yet? I mean sometimes it includes one or two params. May be we need to add sth about this parameter?

vac/raw/decentralized-messaging-ethereum.md Outdated Show resolved Hide resolved
vac/raw/decentralized-messaging-ethereum.md Outdated Show resolved Hide resolved
vac/raw/decentralized-messaging-ethereum.md Outdated Show resolved Hide resolved
vac/raw/decentralized-messaging-ethereum.md Outdated Show resolved Hide resolved
vac/raw/decentralized-messaging-ethereum.md Outdated Show resolved Hide resolved
vac/raw/decentralized-messaging-ethereum.md Outdated Show resolved Hide resolved
vac/raw/decentralized-messaging-ethereum.md Outdated Show resolved Hide resolved
vac/raw/decentralized-messaging-ethereum.md Outdated Show resolved Hide resolved
vac/raw/decentralized-messaging-ethereum.md Outdated Show resolved Hide resolved
vac/raw/decentralized-messaging-ethereum.md Outdated Show resolved Hide resolved
ramsesfv and others added 23 commits May 13, 2024 15:17
@kaiserd kaiserd requested review from seemenkina and seugu May 27, 2024 09:16
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need an approval from @seemenkina before merging

@ramsesfv ramsesfv merged commit 7e3a625 into main May 27, 2024
2 checks passed
@ramsesfv ramsesfv deleted the ETH-SECPM-DEC branch May 27, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants