-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETH-SECPM-DEC #28
ETH-SECPM-DEC #28
Conversation
…d-messaging-ethereum.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, just want to say that the rfc is very detailed and easy to read, thanks for doing such a great job
I have left some corrections regarding the labelling (mainly removed the artefact from the latex)
I would really like to see the code labelled (add tabs) because sometimes I have to go into the text to understand what belongs to which block.
I still have questions about the member-view
function - it's not very clear what kind of data it will work with - only IDs
or something else?
And similarly about gamma.history
- I understand that this is a set of actions that the user has performed in the form of an array of sequences like op = ("action", sender, seq, <additional data> )
. And <additional data>
is not specified yet? I mean sometimes it includes one or two params. May be we need to add sth about this parameter?
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
Co-authored-by: seugu <[email protected]>
Co-authored-by: seugu <[email protected]>
Co-authored-by: seugu <[email protected]>
Co-authored-by: seugu <[email protected]>
Co-authored-by: Ekaterina Broslavskaya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but need an approval from @seemenkina before merging
No description provided.