feat(RewardsStreamerMP): introduce leave() function #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
force-pushed
the
feat/leave-upgradable
branch
from
0477df4 to
175e3b5
Compare
0x-r4bbit
changed the base branch from
proxy-upgradability
to
feat/upgradeability
0x-r4bbit
changed the title
0x-r4bbit
force-pushed
the
feat/upgradeability
branch
from
9ebd0ff to
9539e9a
Compare
0x-r4bbit
force-pushed
the
feat/leave-upgradable
branch
from
175e3b5 to
3e6c25e
Compare
3 tasks
0x-r4bbit
force-pushed
the
feat/upgradeability
branch
from
9539e9a to
a30eb94
Compare
0x-r4bbit
force-pushed
the
feat/leave-upgradable
branch
from
3e6c25e to
ec2dc08
Compare
3esmit
reviewed
Nov 29, 2024
| @@ -136,13 +189,11 @@ contract StakeVault is Ownable { | |||
| } | |||
|
|
|||
| function _stake(uint256 _amount, uint256 _seconds, address _source) internal { | |||
| stakeManager.stake(_amount, _seconds); | |||
There was a problem hiding this comment.
Any reason for reordering this?
There was a problem hiding this comment.
Just o adhere to CEI pattern. I think this should've been the case from the get go.
|
|
||
| import { ERC1967Proxy } from "@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy.sol"; | ||
|
|
||
| contract StakeManagerProxy is ERC1967Proxy { |
There was a problem hiding this comment.
Is this contract going to be deployed? If not, it should be an interface, or at least abstract.
I think that having the IStakeManagerProxy should be enough. Why we need this?
There was a problem hiding this comment.
We need a contract that exposes the implementation address of the ERC1967 proxy via a public function.
Otherwise StakeVault is unable to determine the implementation address of the StakeManager as there's no way to get the value of a storage slot of an external contract within the EVM.
That proxy implementation here is the one that will be deployed for every stakemanager.
| @@ -29,7 +31,7 @@ contract RewardsStreamerMPTest is Test { | |||
| bytes memory initializeData = | |||
| abi.encodeCall(RewardsStreamerMP.initialize, (address(this), address(stakingToken), address(rewardToken))); | |||
| address impl = address(new RewardsStreamerMP()); | |||
| address proxy = address(new ERC1967Proxy(impl, initializeData)); | |||
| address proxy = address(new StakeManagerProxy(impl, initializeData)); | |||
There was a problem hiding this comment.
Why can't we use the default proxy?
There was a problem hiding this comment.
3esmit
approved these changes
Nov 29, 2024
0x-r4bbit
force-pushed
the
feat/upgradeability
branch
from
a30eb94 to
816f72b
Compare
This function allows users to `leave()` the system if they can't or don't want to trust the stake manager. This is the case when the owner of the stake manager performs an upgrade. In case of such an upgrade, the stake manager will be marked as not trusted which prevents the user from staking, unstaking, locking etc. The user can then either explicitly trust stake manager (will happen in future changes) to enable the vault's functionality again, or, `leave()` the system at which point it will try to perform a benign `leave()` operation and then move the funds out of the vault. Closes #66
…k overflow If there's a malicious upgrade which causes a stack overflow error when `leave()` is called, the user of the vault should still be able to get their funds out. This commit adds a test that proofs this is happening.
0x-r4bbit
force-pushed
the
feat/leave-upgradable
branch
from
dfe8929 to
09fc92d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function allows users to
leave()the system if they can't ordon't want to trust the stake manager. This is the case when the owner
of the stake manager performs an upgrade.
In case of such an upgrade, the stake manager will be marked as not
trusted which prevents the user from staking, unstaking, locking etc.
The user can then either explicitly trust stake manager (will happen in
future changes) to enable the vault's functionality again, or,
leave()the system at which point it will try to perform a benign
leave()operation and then move the funds out of the vault.
Closes #66