Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose good practise #79

Merged
merged 1 commit into from
May 13, 2022
Merged

Propose good practise #79

merged 1 commit into from
May 13, 2022

Conversation

amenk
Copy link
Contributor

@amenk amenk commented May 5, 2021

I would like to promote the practise to mark changes, because fellow developers might search a lot if vendor was changed when debugging errors.

Feel free to accept if you agree.

Thanks for the great work :-)

@amenk
Copy link
Contributor Author

amenk commented May 5, 2021

would be obosolete with #69

@allanpaiste
Copy link
Contributor

allanpaiste commented May 7, 2021

Ah yes I love this! Another good practice to mention to people would probably be to not to remove big blocks of code and rather comment them out with extra notification as those also will cause confusion when someone expects certain logic to be found but finds nothing (not even a comment that something was removed).

Anyhow having this in docs would be a very cool step towards the enhancement in issues already, yes :)

Will merge this over the weekend :)

@peterjaap
Copy link
Contributor

@zamoroka while you're merging, can you do this one as well? :)

@zamoroka zamoroka merged commit 5364b37 into vaimo:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants