Bump spotbugs-maven-plugin from 4.2.3 to 4.3.0

valentjn · Jul 12, 2021 · a367f6a · a367f6a
1 parent bad1034
commit a367f6a
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/.spotbugs-exclude.xml b/.spotbugs-exclude.xml
@@ -8,7 +8,7 @@
    -->
 <FindBugsFilter>
   <Match>
-    <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE,NP_NONNULL_PARAM_VIOLATION,NP_NONNULL_RETURN_VIOLATION,NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE,NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE,RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
+    <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE,EI_EXPOSE_REP,EI_EXPOSE_REP2,NP_NONNULL_PARAM_VIOLATION,NP_NONNULL_RETURN_VIOLATION,NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE,NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE,RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
   </Match>
   <Match>
     <Class name="org.bsplines.ltexls.parsing.CodeAnnotatedTextBuilder"/>

diff --git a/pom.xml b/pom.xml
@@ -199,7 +199,7 @@
       <plugin>
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
-        <version>4.2.3</version>
+        <version>4.3.0</version>
         <configuration>
           <excludeFilterFile>.spotbugs-exclude.xml</excludeFilterFile>
           <includeTests>true</includeTests>

diff --git a/src/main/java/org/bsplines/ltexls/languagetool/LanguageToolJavaInterface.java b/src/main/java/org/bsplines/ltexls/languagetool/LanguageToolJavaInterface.java
@@ -48,7 +48,7 @@ public class LanguageToolJavaInterface extends LanguageToolInterface {
 
   public LanguageToolJavaInterface(String languageShortCode, String motherTongueShortCode,
         int sentenceCacheSize, Set<String> dictionary) {
-    this.dictionary = dictionary;
+    this.dictionary = Set.copyOf(dictionary);
 
     if (!Languages.isLanguageSupported(languageShortCode)) {
       Tools.logger.severe(Tools.i18n("notARecognizedLanguage", languageShortCode));

diff --git a/src/main/java/org/bsplines/ltexls/languagetool/LanguageToolRuleMatch.java b/src/main/java/org/bsplines/ltexls/languagetool/LanguageToolRuleMatch.java
@@ -8,6 +8,7 @@
 package org.bsplines.ltexls.languagetool;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import java.util.regex.Pattern;
 import org.bsplines.ltexls.parsing.AnnotatedTextFragment;
@@ -75,7 +76,7 @@ public String getMessage() {
   }
 
   public List<String> getSuggestedReplacements() {
-    return this.suggestedReplacements;
+    return Collections.unmodifiableList(this.suggestedReplacements);
   }
 
   public void setFromPos(int fromPos) {

diff --git a/src/main/java/org/bsplines/ltexls/parsing/latex/LatexCommandSignatureMatch.java b/src/main/java/org/bsplines/ltexls/parsing/latex/LatexCommandSignatureMatch.java
@@ -25,7 +25,7 @@ public LatexCommandSignatureMatch(LatexCommandSignature commandSignature, String
     this.toPos = (argumentPos.isEmpty()
         ? (fromPos + commandSignature.getPrefix().length())
         : argumentPos.get(argumentPos.size() - 1).getValue());
-    this.argumentPos = argumentPos;
+    this.argumentPos = List.copyOf(argumentPos);
   }
 
   public LatexCommandSignature getCommandSignature() {