Replace the term SSL with TLS #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
Use the name libvalkey_tls instead of libavalkey_ssl. Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
CMake builds now accepts ENABLE_TLS instead of ENABLE_SSL. Make builds now accepts USE_TLS instead of USE_SSL. Standalone test.sh now accepts TEST_TLS instead of TEST_SSL. Signed-off-by: Björn Svensson <[email protected]>
Signed-off-by: Björn Svensson <[email protected]>
zuiderkwast
approved these changes
Sep 25, 2024
michael-grunder
approved these changes
Sep 25, 2024
I guess so, this is an additional change to their builds besides fiddling with new header paths and library names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of the term
SSLwithTLS, as done invalkey, and is mainly a search and replace but grouped in related chunks. The change can be reviewed in separate steps, each step is an own commit with a green CI.But still, sorry about the size..
The commits are:
Remove forward declaration of non-existing struct valkeySslThis is a on-line cleanup.
Rename files to use 'tls' instead of 'ssl'in own commit.Updates needed after file renamingMaking the build pass after renaming files.
Rename ssl library and examplesUse the name
libvalkey_tlsinstead oflibavalkey_ssl, update CMakeLists/Makefile and rename example binaries.Update API and functions to use tls instead of sslRename public API, and internal types and code.
Update build and test flagsCMake builds now accepts
ENABLE_TLSinstead ofENABLE_SSL.Make builds now accepts
USE_TLSinstead ofUSE_SSL.Standalone test.sh now accepts
TEST_TLSinstead ofTEST_SSL.Update docs and migration guide