Remove parsing of unused cluster slot information #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no usage of the parsed "importing" and "migrating" information, which is only provided by CLUSTER NODES. Let's remove this superfluous code since we rely on ASK redirections, which will be emitted when a slot is in "migrating" state. Signed-off-by: Björn Svensson <[email protected]>
zuiderkwast
approved these changes
Jun 27, 2024
There are no tests covering that as I know, but I added #33 to improve that. |
michael-grunder
pushed a commit
to michael-grunder/libvalkey
that referenced
this pull request
Aug 1, 2024
Currently there is no usage of the parsed `importing` and `migrating` information, which is only provided by `CLUSTER NODES`. Let's remove this superfluous code since we rely on `ASK` redirections, which will be emitted when a slot is in `migrating` state. Signed-off-by: Björn Svensson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no usage of the parsed
importingandmigratinginformation,which is only provided by
CLUSTER NODES.Let's remove this superfluous code since we rely on
ASKredirections,which will be emitted when a slot is in
migratingstate.