Valkey Over RDMA[1] has been supported as experimental feature since Valkey 8.0. Support RDMA transport for the client side. RDMA is not a builtin feature, supported as module only, so we have to run test.sh with more argument @VALKEY_RDMA_MODULE and @VALKEY_RDMA_ADDR. An example to run test.sh: VALKEY_RDMA_MODULE=/path/to/valkey-rdma.so VALKEY_RDMA_ADDR=192.168.122.1 TEST_RDMA=1 ./test.sh ... Testing against RDMA connection (192.168.122.1:56379): valkey-io#138 Is able to deliver commands: PASSED valkey-io#139 Is a able to send commands verbatim: PASSED valkey-io#140 %s String interpolation works: PASSED valkey-io#141 %b String interpolation works: PASSED valkey-io#142 Binary reply length is correct: PASSED valkey-io#143 Can parse nil replies: PASSED valkey-io#144 Can parse integer replies: PASSED valkey-io#145 Can parse multi bulk replies: PASSED valkey-io#146 Can handle nested multi bulk replies: PASSED valkey-io#147 Send command by passing argc/argv: PASSED valkey-io#148 Can pass NULL to valkeyGetReply: PASSED valkey-io#149 RESP3 PUSH messages are handled out of band by default: PASSED valkey-io#150 We can set a custom RESP3 PUSH handler: PASSED valkey-io#151 We properly handle a NIL invalidation payload: PASSED valkey-io#152 With no handler, PUSH replies come in-band: PASSED valkey-io#153 With no PUSH handler, no replies are lost: PASSED valkey-io#154 We set a default RESP3 handler for valkeyContext: PASSED valkey-io#155 We don't set a default RESP3 push handler for valkeyAsyncContext: PASSED valkey-io#156 Our VALKEY_OPT_NO_PUSH_AUTOFREE flag works: PASSED valkey-io#157 We can use valkeyOptions to set a custom PUSH handler for valkeyContext: PASSED valkey-io#158 We can use valkeyOptions to set a custom PUSH handler for valkeyAsyncContext: PASSED valkey-io#159 We can use valkeyOptions to set privdata: PASSED valkey-io#160 Our privdata destructor fires when we free the context: PASSED valkey-io#161 Successfully completes a command when the timeout is not exceeded: PASSED valkey-io#162 Does not return a reply when the command times out: SKIPPED valkey-io#163 Reconnect properly reconnects after a timeout: PASSED valkey-io#164 Reconnect properly uses owned parameters: PASSED valkey-io#165 Returns I/O error when the connection is lost: PASSED valkey-io#166 Returns I/O error on socket timeout: PASSED #167 Set error when an invalid timeout usec value is used during connect: PASSED #168 Set error when an invalid timeout sec value is used during connect: PASSED #169 Append format command: PASSED #170 Throughput: (1000x PING: 0.010s) (1000x LRANGE with 500 elements: 0.060s) (1000x INCRBY: 0.012s) (10000x PING (pipelined): 0.066s) (10000x LRANGE with 500 elements (pipelined): 0.523s) (10000x INCRBY (pipelined): 0.024s) ... Thanks to Michael Grunder for lots of review suggestions! Link[1]: valkey-io/valkey#477 Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>

Commits

Commits on Jul 30, 2024

Fully abstract IO framework

Fix timing issue on reconnect

Introduce RDMA transport (experimental)

Add cmake support for RDMA